Closed Bug 1506113 Opened 6 years ago Closed 5 years ago

Menu Bar and Tab Bar are not visible with High Contrast White Theme when not drawing in the title bar

Categories

(Firefox :: Theme, defect, P2)

x86_64
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 66
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- verified

People

(Reporter: cbadau, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image issueHighContrast.png
[Affected versions]:
- Firefox 64 Beta 8 (20181108141956)
- Nightly 65.0a1 (2019-11-09)
- Firefox 63.0.1

[Affected platforms]:
- Windows 8.1 x86

[Steps to reproduce]:
1. Set High Contrast White Theme (Right-click -> Personalize -> Colors -> High Contrast Settings).
2. Launch Firefox.
3. Click on Hamburger menu -> select "Customize".
4. From the bottom of the page activate the "Title Bar".
5. Observe the Menu Bar and the Tab Bar.

[Expected result]:
- All the options from Menu Bar and the tabs name are visible. 

[Actual result]:
- The options from Menu Bar and the tabs name aren't visible (these are only visible if you hover over them).

[Regression range]:
- This is not a recent regression. I will come back with the regression range ASAP. 

[Additional notes]:
- This is Windows 8.1 specific issue.
Any update regarding the regression range?
Flags: needinfo?(camelia.badau)
I have 2 regression ranges here:

- first regression range is for the case when Menu Bar isn't visible with High Contrast White Theme -> here is the pushlog URL: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bbc9b2b50815f2d48492c0b5434804605438b9a0&tochange=f605d6efe3476538613b0fcca7d2582c2a3606cc

I think that bug 1437052 is causing the problem. 

- second regression range is for the case when Menu Bar is visible, but the tabs name aren't visible (with High Contrast White Theme); it seems that this issue (that the tabs name isn't visible) appeared in build when Title Bar was included in "Customize" -> here is the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73eefb421e2a&tochange=d09f9a9f81ae
Flags: needinfo?(camelia.badau)
Blocks: 1437052
Priority: -- → P3
Summary: Menu Bar and Tab Bar are not visible with High Contrast White Theme → Menu Bar and Tab Bar are not visible with High Contrast White Theme when not drawing in the title bar
Windows 10 is affected too.
Assignee: nobody → dao+bmo
OS: Windows 8.1 → Windows 10
Priority: P3 → P2
(In reply to Dão Gottwald [::dao] from comment #3)
> Windows 10 is affected too.

Alas, Windows 8.1 and 10 don't share the responsible theme code. And since I can't currently test on 8.1, I'll only take care of Windows 10 here.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10279adac5c0
With the native title bar enabled, stop using -moz-win-glass on Windows 10 / high contrast. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/10279adac5c0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Please request Beta approval on this when you get a chance.
Flags: qe-verify+
Flags: needinfo?(dao+bmo)
I have reproduced this bug with Nightly 65.0a1 (2018-11-09) on Windows 10, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID 	20181228215042
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
QA Whiteboard: [bugday-20181226]

Per IRC discussion with Felipe, going to let this ride the trains.

Flags: needinfo?(dao+bmo)

The bug is fixed on Windows 10 64bit/32bit on latest Nightly 66.0a1 (2019-01-16).

But the issue is still reproducible on Windows 8.1 32bit. The bug will be fixed here?

(In reply to Camelia Badau [:cbadau], Release Desktop QA from comment #11)

But the issue is still reproducible on Windows 8.1 32bit. The bug will be fixed here?

Unlikely, given the low market share of Windows 8.1.

Marking the issue as VERIFIED FIXED based on previous comment.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: