Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 6 years ago

There are multiple implementations of a thing call DotDict in the Socorro codebase. One of them comes from configman. The other is a shorthand implementation in socorro.lib.util that extends dict to allow it to use dot notation.

The problem with the one in socorro.lib.util is that it breaks the contact for __getattr__ namely that it raises KeyError rather than AttributeError and that causes a bunch of problems in Python 3.

This bug covers either removing this second DotDict from the codebase or reimplementing it such that it abides by the contact for attributes.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 6 years ago

Grabbing this to do now.

	[github robot]
	Comment 3 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/f4211934926ef85a496cf4e295e5830e9efd3a99
fix bug 1505797: remove socorro's DotDict

This removes one of the DotDicts from the codebase. Now there's only the
configman DotDict.

One architectural change this required was in crashstorage. Previously,
save_raw_and_processed would take DotDicts for the raw_crash and
processed_crash. Now the processor converts the two crash structures
into dicts before calling save_raw_and_processed.

https://github.com/mozilla-services/socorro/commit/6fa5f10aa1a824bcbf1e7ce8a1ea11aedf023430
Merge pull request #4701 from willkg/1505797-dotdict

fix bug 1505797: remove socorro's DotDict