Cristian Fogel [:cfogel] Reporter
	Description • 6 years ago

[Affected versions]:
- 65.0a1 (2018-11-06) 

[Affected platforms]:
- Win 10x64, Ubuntu 16.04LTS, macOS 10.13;

[Steps to reproduce]:
1. Launch Firefox;
2. Open any local file;
3. Press F12 on the keyboard;
4. Click on the RDM button;

[Expected result]:
- RDM ui is properly displayed;

[Actual result]:
- the icon for the no throttling button is wrongly positioned;

[Regression range]:
- bug 1459539 seems to have caused the issue;

[Additional notes]:
- attached screenshot with the issue;

	Cristian Fogel [:cfogel] Reporter
	Comment 1 • 6 years ago

Hey there, the positioning of the icon is a bit off.

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 3 • 6 years ago

Comment on attachment 9023087 [details] [diff] [review]
1505073.patch [1.0]

Review of attachment 9023087 [details] [diff] [review]:
-----------------------------------------------------------------

@Heng Yeow: what do you think about this? (related to bug 1459539)

Honza

	Hengyeow (:tanhengyeow)
	Comment 4 • 6 years ago

Comment on attachment 9023087 [details] [diff] [review]
1505073.patch [1.0]

Review of attachment 9023087 [details] [diff] [review]:
-----------------------------------------------------------------

Tested manually and it looks good! 

Should have clarified on other components that share this style when making the change for Bug 1459539 :P

Thank you Gabriel for the fix!

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 6 • 6 years ago

(In reply to Heng Yeow (:tanhengyeow) from comment #4)
> Comment on attachment 9023087 [details] [diff] [review]
> 1505073.patch [1.0]
> 
> Review of attachment 9023087 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Tested manually and it looks good! 
> 
> Should have clarified on other components that share this style when making
> the change for Bug 1459539 :P
Thanks for testing!

Honza

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 7 • 6 years ago

Comment on attachment 9023087 [details] [diff] [review]
1505073.patch [1.0]

Review of attachment 9023087 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay with the review.

Thanks!
Honza

	Pulsebot
	Comment 8 • 6 years ago

Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f052d5b3a612
Fix the arrow positioning for the network throttling menu button in RDM. r=Honza

	Cristina Coroiu [:ccoroiu]
	Comment 9 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f052d5b3a612

	Cristian Fogel [:cfogel] Reporter
	Comment 10 • 6 years ago

Verified with 65.0a1 (2018-11-22) on Win10x64, macOS 10.13, Ubuntu16.04.