Vlad Lucaci, Desktop QA (:vlucaci) Reporter
	Description • 6 years ago

[Affected versions]:
- 65.0a1 (2018-11-02) 
- 64.0b6
- 63.0a1 (2018-07-05)

[Affected platforms]:
-Ubuntu 16.04
-Ubuntu 18.04

[Steps to reproduce]:
1. Open FF.
2. Open multiple tabs with various pages (ex: Facebook, Youtube, Reddit, IMDB etc)
3. Select all of the tabs.
4. Press CTRL+SHIFT+D


[Expected result]:
- The New bookmarks prompt is displayed and all the tabs are bookmarked after confirming the prompt.

[Actual result]:
- The New bookmarks prompt is not displayed and all the tabs cannot be bookmarked.

[Regression range]:
-This issue is not a regression.

[Additional notes]:
-This issue is not present on other platforms (Windows and macOS)

	Dão Gottwald [:dao] Assignee
	Comment 1 • 6 years ago

Jared, please prioritize. Thanks.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 2 • 6 years ago

This is intentional and not supported in GTK per this comment,
https://searchfox.org/mozilla-central/rev/6e0e603f4852b8e571e5b8ae133e772b18b6016e/browser/base/content/browser-sets.inc#234

	Dão Gottwald [:dao] Assignee
	Comment 3 • 6 years ago

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #2)
> This is intentional and not supported in GTK per this comment,
> https://searchfox.org/mozilla-central/rev/
> 6e0e603f4852b8e571e5b8ae133e772b18b6016e/browser/base/content/browser-sets.
> inc#234

Hmm, is this accurate and still up to date? Shift+Accel+D doesn't seem to do anything on Ubuntu 18.10. Also, we use Shift+Accel+A for about:addons, although that shortcut actually does something in multi-line text fields...

	Jared Wein [:jaws] (please needinfo? me)
	Comment 4 • 6 years ago

Martin, do you know anything about the usage of Shift+Accel+D on GTK? Is this still reserved in some circumstances? See comment #2 and comment #3.

	Martin Stránský [:stransky] (ni? me)
	Comment 5 • 6 years ago

Control-Shift-D is used to open interactive debugger in gnome when Gtk+ debugging is enabled (https://wiki.gnome.org/Projects/GTK+/Inspector). Not sure how is that relevant for Firefox users and I'd say it's safe to use it in Firefox.

	Martin Stránský [:stransky] (ni? me)
	Comment 6 • 6 years ago

(In reply to Martin Stránský [:stransky] from comment #5)
> Control-Shift-D is used to open interactive debugger in gnome when Gtk+
> debugging is enabled (https://wiki.gnome.org/Projects/GTK+/Inspector). Not
> sure how is that relevant for Firefox users and I'd say it's safe to use it
> in Firefox.

Ahh, I see the shortcut can be blocked on Gtk+ level...so better don't use that as it depends on actual enabled/disabled debug state of Gtk+ library.

	Dão Gottwald [:dao] Assignee
	Comment 7 • 6 years ago

Well, it seems that if we enable this shortcut and it gets blocked, users aren't worse off than we are now, while users who haven't enabled GtkInspector would benefit.

	Pulsebot
	Comment 9 • 6 years ago

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d349c077a2a
Enable Ctrl+Shift+D shortcut on Linux. r=stransky

	Noemi Erli[:noemi_erli]
	Comment 10 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2d349c077a2a

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 6 years ago

Did you want to let this ride the trains?

	Dão Gottwald [:dao] Assignee
	Comment 12 • 6 years ago

Yep.

	Vlad Lucaci, Desktop QA (:vlucaci) Reporter
	Comment 13 • 6 years ago

Hello all,

Confirming as verified fixed on the Nightly 65.0a1(2018-11-22).

Verified on Ubuntu 16.04x64.