Open Bug 1504197 Opened 6 years ago Updated 2 months ago

Restore All Tabs doesn't work when the only tab that's open is a new tab

Categories

(Firefox :: Session Restore, defect, P3)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix

People

(Reporter: obotisan, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 obsolete file) 

[Affected versions]:
- Firefox 63.0.1
- Firefox 64.0b6
- Nightly 65.0a1

[Affected platforms]:
- macOS 10.13
- Ubuntu 16.04 x64
- Windows 10 x32
- Windows 7 x64

[Steps to reproduce]:
1. Go to https://www.youtube.com/.
2. Open at least two videos in different tabs (using middle click or Ctrl+click).
3. Open a new tab and focus on it.
4. Wait until all the pages are loaded and close all of them, except the tab you are on.
5. Go to Hamburger Menu -> Library -> History -> Recently Closed Tabs -> click on Restore All Tabs.

[Expected result]:
- All the tabs are restored.

[Actual result]:
- Only one tab is restored.

[Regression range]:
- This is a regression because it doesn't reproduce on Nightly from 2017-01-02.
- I will try to find a pushlog as soon as possible.

[Additional notes]:
- If you try again step 5 then all the tabs are restored.
- This issue is reproducing even when the session is restored from Menu Bar.
- If any other site is loaded in a tab, then the issue is not reproducing.
Mozregression couldn't find a pushlog, but I did fin't the last good build and the first bad one:
- last good: 2017-01-23
- first bad: 2017-01-24

I will try to find more helpful info.
See Also: → 1449956
Regression range is almost 2 years old, wontfix for 63.
status-firefox63: affected → wontfix
Mike, can you find anyone to investigate? Would you consider this an edge case or what priority would you give it?
status-firefox64: affected → fix-optional
Flags: needinfo?(mdeboer)
Too late to fix in 64. Marking this issue as fix-optional for 65; if you land a patch in nightly and think it's low-risk for beta, please request uplift.
status-firefox64: fix-optional → wontfix
status-firefox65: affected → fix-optional

Just reproduced this on mac nightly

Blocks: ss-reliability
Priority: -- → P3

Hello,

Mozregression is failing when attempting to search a regression within the timeframe suggested by Oana in Comment 1.

With that information however, the following pushlog was generated manually:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startdate=+2017-01-23&enddate=2017-01-24

From it, the apparent culprit for this regression would be Bug 1332874.

Has Regression Range: --- → yes
Keywords: regressionwindow-wanted

(In reply to Vlad Lucaci (:vlucaci) from comment #6)

Hello,

Mozregression is failing when attempting to search a regression within the timeframe suggested by Oana in Comment 1.

Ouch, that's too bad :(

With that information however, the following pushlog was generated manually:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startdate=+2017-01-23&enddate=2017-01-24

From it, the apparent culprit for this regression would be Bug 1332874.

That bug is touching code that is only ever executed for unit tests, not Firefox release, so it's very unlikely that this is the culprit. So we'll need to continue looking for it, or just give up and fix it without this information.

Has Regression Range: yes → no
Flags: needinfo?(mdeboer)
Keywords: regressionwindow-wanted

3rd time's a charm ... hopefully.

  • First Bad build_date: 2017-02-02 changeset: f985243bb630b2c78cd57731c8d8ab191aa09527
  • Last Good build_date: 2017-02-01 changeset: fe22af79bacf6db526737536eab551caf68ba440
  • Pushlog URL: link
Keywords: regressionwindow-wanted

Bulk change of P3 carryover bugs to wontfix for 68.

status-firefox68: affected → wontfix

Hi,
I've tested this using the latest Nightly version 74.0a1 (2020-01-13) (64-bit) for Ubuntu 18.04.3 LTS and I’m able to reproduce the issue. Based on this I will mark firefox74 flag as affected.
Best,
Clara

status-firefox74: --- → affected

Given that this is P3 I'm marking as fix-optional for nightly 74. Happy to take a patch, but I don't want to have this bug keep coming up in the triage we hold for new regressions.

status-firefox73: --- → wontfix
status-firefox74: affected → fix-optional

Hi,

I was able to reproduce this issue on Mac OS 10.14 for Firefox Nightly version 75.0a1 (2020-02-18) (64-bit). Marking that flag as affected.

status-firefox75: --- → affected
Severity: normal → S3
Attachment #9385044 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: