Brian Grinstead [:bgrins] Reporter
	Description • 6 years ago

Form discussions back when we first shipped v1: "I assume we'll keep the prefs until 64. So, ship in 63 and remove prefs in 65".

If that's still a doable target, we could remove the prefs now. This would make the UA Widget implementations easier since we wouldn't have to continue supporting the in-content XBL implementations for each one.

	Brian Grinstead [:bgrins] Reporter
	Comment 1 • 6 years ago

Smaug, what do you think?

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 2 • 6 years ago

This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references.

I didn't change the tests that loads Shadow DOM tests in an iframe,
in the interest of keeping hg annotation history.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 3 • 6 years ago

This patch removes the following functions:

* nsContentUtils::IsCustomElementsEnabled()
* CustomElementRegistry::IsCustomElementEnabled(JSContext* aCx, JSObject* aObject)
* CustomElementRegistry::IsCustomElementEnabled(nsIDocument* aDoc)

and all references of the pref.

Depends on D11183

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 4 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=42f472cfc6cd3c450836e8bb285ad53fb2531fc0

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 5 • 6 years ago

There are a few bugs in-flight that should be landed before this.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 6 • 6 years ago

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5)
> There are a few bugs in-flight that should be landed before this.

It turned out they don't touch the same lines of code, so I am going to rebase the patches and try to land it.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0bc7db58e5817c0ebc3ddbd752b899a27d13cd1

	Pulsebot
	Comment 7 • 6 years ago

Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b845eac9dd7
Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
https://hg.mozilla.org/integration/autoland/rev/06b12fd41ff1
Part II, Remove dom.webcomponents.customelements.enabled pref r=smaug

	Andreea Pavel [:apavel]
	Comment 8 • 6 years ago

Backed out for failing crashtests dom/base/crashtests/1505811.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=06b12fd41ff14bbcba2d2bf268ad5da44496a02a

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211809337&repo=autoland&lineNumber=2657

Backout: https://hg.mozilla.org/integration/autoland/rev/0210ae2d20cc9637f496df75e0515843e3587700

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 9 • 6 years ago

Need to rebase -- keeping needinfo.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 10 • 6 years ago

Just trigger landing again before other patches break them...

	Pulsebot
	Comment 11 • 6 years ago

Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35994714f03a
Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
https://hg.mozilla.org/integration/autoland/rev/e952a2b3d4ef
Part II, Remove dom.webcomponents.customelements.enabled pref r=smaug

	Arthur Iakab [arthur_iakab]
	Comment 12 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/35994714f03a
https://hg.mozilla.org/mozilla-central/rev/e952a2b3d4ef

	ExE Boss
	Comment 15 • 6 years ago

Setting dev‑doc‑needed so that relevant MDN pages can be updated, as they list about:config preference information.

	Chris Mills [:cmills]
	Comment 16 • 5 years ago

Note to MDN writers:

I have added a note about this to the Fx65 rel notes; see the removals subsection of
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

However I am not very happy about the browser compat data situation — if you look at say

https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry

You'll see that it says available from 63 in Firefox, but it also says it is behind a pref from Fx 59-65, which contradicts the first information.

I think we need to simplify the data to just say "available from 63", or "available from 63, and before that, behind a pref". 

To do otherwise is really confusing. Once a feature is enabled by default, 99.9% of devs really don't care if there are prefs that control them or not.

Apart from sorting out the compat data, this one is finished.