Closed Bug 1501954 Opened 6 years ago Closed 6 years ago

The about:policies page displays no error if certificates are not being located inside the correct path

Categories

(Firefox :: Enterprise Policies, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1506734
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- affected
firefox65 --- affected

People

(Reporter: emilghitta, Unassigned, Mentored)

References

Details

Attachments

(1 file)

Attached file policies.json
[Affected versions]:
Firefox 65.0a1 (BuildId:20181024221315).
Firefox 64.0b3 (BuildId:20181022150107).

[Affected platforms]:
Windows 10 64bit.
macOS 10.13.6
Ubuntu 16.04 64bit.

[Preconditions]:
1. Place the attached policies.json file inside the "distribution" folder.
2. Make sure you don't have any certificates placed inside the correct path.

[Steps to reproduce]:
1. Launch Firefox.
2. Access the about:policies page.

[Expected result]:
Since no certificates are found inside the required path, an error is displayed inside the about:policies page stating that the Certificates policy is not applied. 

[Actual result]:
No errors are displayed inside the about:policies page.

[Notes]
I have attached a policies.json file that reproduces this issue.
Mentor: felipc
Keywords: good-first-bug
Priority: -- → P5
Whiteboard: [lang=js]
(Sorry, I confused this bug with bug 1497928. This one is not a good-first-bug, so let me adjust the flags)
Keywords: good-first-bug
Priority: P5 → P3
Whiteboard: [lang=js]
So the issue here is that the certificate could be in up to three locations, so there was no clever way to know at the end that no certificate was found.
I am new here . I want to work on this bug . Looking for mentorship to get started. Thank you.
> I am new here . I want to work on this bug . Looking for mentorship to get started. Thank you.

Sure.

If you look here:

https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/Policies.jsm#141

You'll see that we look in multiple locations for the certificates.

Because the certificate can be in one place and not another, we don't want to show an error every time we don't find a certificate.

We want to keep track of our search for the certificate and if we never find it, show an error.
So I actually fixed this as part of the rewrite in bug 1506734.

I'll be more than happy to find another bug for you to look at.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: