Closed
Bug 1501506
Opened 6 years ago
Closed 6 years ago
Add -webkit-appearance:progress-bar and make that the default for <progress> for compatibility with other UAs
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: dev-doc-complete, testcase)
Attachments
(2 files)
1.07 KB,
text/html
|
Details | |
29.54 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
We should add a new 'progress-bar' value to '-webkit-appearance' in
the style system, and make the existing 'progressbar' value an
alias for 'progress-bar'.
We should also replace any existing 'progressbar' values in our
UA sheets with 'progress-bar'. In particular, the default value
for <progress>.
Chrome/Safari uses '-webkit-appearance:progress-bar' on <progress>.
Setting '-webkit-appearance:none' removes the theme and renders
a grey background instead. Setting display:inline appears to work.
display:contents behaves as display:none.
Edge, on the other hand, uses '-webkit-appearance:none'
by default on <progress>.
Setting display:inline appears to work.
No UA renders the <progress> contents in any case.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → mats
Assignee | ||
Comment 2•6 years ago
|
||
Keep our old 'progressbar' as an alias for now, but unship
'progresschunk' by restricting it to UA/chrome sheets only.
Unship 'progresschunk-vertical' by removing it since it's
not used internally for anything.
Attachment #9023256 -
Flags: review?(jwatt)
![]() |
||
Comment 3•6 years ago
|
||
Comment on attachment 9023256 [details] [diff] [review]
Add -webkit-appearance:progress-bar and make that the default for <progress> for compatibility with other UAs.
Review of attachment 9023256 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Attachment #9023256 -
Flags: review?(jwatt) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55a4f0f8ceaa
Add -webkit-appearance:progress-bar and make that the default for <progress> for compatibility with other UAs. r=jwatt
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Keywords: dev-doc-needed
Comment 7•6 years ago
|
||
Note to MDN writers:
I've added a note to the Fx65 rel notes to cover this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#CSS
As for the docs, this should be a simple matter of adding the value to the appearance reference page and the compat data.
Comment 8•6 years ago
|
||
Use the testcase from comment 0 for verifying this issue.
QA Whiteboard: [good first verify]
Comment 9•6 years ago
|
||
Updated the table to add progress-bar support for FF, made it standard, and added comment on progressbar to use progress-bar instead. https://developer.mozilla.org/en-US/docs/Web/CSS/appearance
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•