Cristian Fogel [:cfogel] Reporter
	Description • 6 years ago

[Note]:
- website issue - enhancement suggestion
- not a product issue

[Affected platforms]:
- all

[Steps to reproduce]:
1. Access the following link: https://crash-stats.mozilla.com/
2. In the quick navigation click on the [Current versions], [Overview] dropdown buttons; 

[Expected result]:
- dropdowns are displayed as expected;

[Actual result]:
- the first options have some extra padding/margins on the top-bottom side;
- hovering over them is unpleasant;

[Enhancement sugestion]:
- increase contrast;
- remove the spacing and add a separator-line in between;

[Regression range]:
- not a regression;

[Additional notes]:
- attached recording with the mentioned sections

	Gabriele Svelto [:gsvelto]
	Comment 1 • 6 years ago

Moving this to the appropriate component.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 6 years ago

Seems like there are a couple of different issues here:

1. some drop down menus have an empty space, but should have a -- to separate between sections
2. increase contrast of something

Does that sound right?

Can you explain what you mean by "increase contrast"?

	Cristian Fogel [:cfogel] Reporter
	Comment 3 • 6 years ago

Thanks for the section correction.

1. Example, for Current Versions:
------------------

Current Versions

64.0a1
------------------


Same separation could be done with the layout bellow:
------------------
Current Versions
----
64.0a1
------------------

The reasoning is that for some users it might be unpleasant to hover over a block of nothing and have to scroll down to the desired version / list element. 
In the Overview section, there are 4 list slots for 2 options.

2. It was either/or 
I might be wrong, but at some point it seemed that the spacing had a light_grey shade; so the suggestion would have been to adjust the colors to make the separation of sections clear. So this point could be ignored.

	[github robot]
	Comment 5 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/cb33e1c40e513597beec4ed40c9b5f6752d775ac
fix bug 1499381: fix optgroups in dropdowns

The navigation dropdown contents have changed significantly over time. This
tweaks the HTML to reduce some of the sparseness now that we've removed
a lot.

https://github.com/mozilla-services/socorro/commit/8a4d0f0bf9c9cf1cb67b1f0f4820a1d594144909
Merge pull request #4649 from willkg/1499381-dropdowns

fix bug 1499381: fix optgroups in dropdowns

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 6 years ago

I changed around the optgroups. It should cover the issues you had.

	Cristian Fogel [:cfogel] Reporter
	Comment 7 • 6 years ago

Awesome!
Thank you for taking it into consideration.