Adding a search engine that was removed by the policies.json remains even after restarting Firefox
Categories
(Firefox :: Enterprise Policies, defect, P4)
Tracking
()
People
(Reporter: emilghitta, Assigned: mkaply)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr91+
|
Details | Review |
[Affected versions]:
Firefox 64.0a1
Firefox 63.0b14
Firefox 62.0.3
Firefox 60.2.2 esr
[Affected platforms]:
Windows 10 64bit.
macOS 10.13.6
Ubuntu 16.04 64bit.
[Preconditions]
Add the following code inside the policies.json file:
{
"policies": {
"SearchEngines": {
"Remove": ["Google"]
}
}
}
[Steps to reproduce]:
1. Launch Firefox.
2. Access the about:preferences#search page.
3. Click the "Restore Default Search Engines" button.
4. Restart Firefox.
[Expected result]:
"Google" search engine is no displayed.
[Actual result]:
"Google" search engine is displayed (since this is a runOnce policy).
I think that we could add the same behavior as in Bug 1498223 for this policy as well.
|
||
Comment 1•6 years ago
|
||
Ideally we wouldn't have any runOnce policies, but they are a compromise to some things that are harder/not worth to do on every startup. The built-in engines can't really be removed and it causes this trouble with the Restore button. A non built-in engine wouldn't suffer from this. This could be worked around similarly as in bug 1498223 but it's not something that I think we should spend time at the moment.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/633eedada836 Remove engines hidden by policy after restoring defaults. r=Standard8
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 6•2 years ago
|
||
Comment on attachment 9270776 [details]
Bug 1499095 - Remove engines hidden by policy after restoring defaults. r?Standard8
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: ESR only search related function, parity with 101
- User impact if declined: Search engines don't add remove completely
- Fix Landed on Version: 101
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Automated test ESR only
|
|
||
Comment 7•2 years ago
|
||
Comment on attachment 9270776 [details]
Bug 1499095 - Remove engines hidden by policy after restoring defaults. r?Standard8
Approved for 91.10esr.
|
|
||
Comment 8•2 years ago
|
||
| bugherder uplift | ||
|
Reporter | |
Comment 9•2 years ago
|
||
Hey Mike!
Unfortunately I'm still able to reproduce this issue using Firefox 91.10.0esr (provided in comment 8) on Windows 10 64bit.
After clicking the "Restore Default Search Engines" & refreshing the about:preferences#search, the Google search engine is displayed inside the Search Engine list. After restarting Firefox (Or after closing/re-opening Firefox), the Google search engine persists and is set as the default search engine.
Can you please take a look? Thank you!
|
|
Assignee | |
Comment 10•2 years ago
|
||
Sorry, took me forever to get to this. You're right it doesn't seem to be working.
Can you open a new bug? I'll take a look.
I fixed something, just not everything :)
|
|
Assignee | |
Comment 11•2 years ago
|
||
So Google is the only engine it doesn't work for because there is later code that unhides the app default engine.
Thanks for finding this!
|
|
Reporter | |
Comment 12•2 years ago
|
||
(In reply to Mike Kaply [:mkaply] from comment #10)
Can you open a new bug? I'll take a look.
Sure thing! Filled Bug 1797965 for the Google case. (Sorry for the delay. I was in PTO)
Description
•