Gabi Cheta [:Gabi] Desktop QA Reporter
	Description • 6 years ago

[Affected versions]: 
- 63.0b13 
- 64.0a1 

[Affected platforms]:
- Windows 7 x64
- Windows 10 x64


[Steps to reproduce]:
 Preconditions:
- Have some bookmarks and browsing in Internet Explorer.

1. Opnen Fx with a clean profile 
2. Import Bookmarks and all the data from Internet Explorer browser.
"Ctrl+Shift+B" -> "Import and Backup" -> "Import Data from Another Browser
3. Open a new tab
4. Observe the Activity Stream Top Sites/Highlights

[Expected result]:
- The most accessed websites imported from Internet Explorer are now displayed in top sites.
- Bookmarked sites, recent downloads and recently visited sites are displayed as Highlights

[Actual result]:
- Top sites and Highlights are not displayed in the new tab when importing data from IE

[Regression range]: 
- Will return with regression asap.

[Additional Notes]:
- The issue is not reproducible on 62.0.3 
- Highlights and top sites are displayed when imported from Chrome and Edge

	Jared Wein [:jaws] (please needinfo? me)
	Comment 1 • 6 years ago

Gabi, are you able to run a regression search for this?

	Ed Lee :Mardak
	Comment 2 • 6 years ago

andreio had some comments in our triage that didn't make it into this bug. It was something along the lines of how the importer works from IE and results in all pages getting the same timestamp / frecency?

	Ed Lee :Mardak
	Comment 3 • 6 years ago

Or maybe it's this comment?

      // use the current date if we have no visits for this entry.
https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/browser/components/migration/IEProfileMigrator.js#61-62

	Gabi Cheta [:Gabi] Desktop QA Reporter
	Comment 4 • 6 years ago

Regression:
pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4cd4b00bfb1721ded728badd698aaed3647552e2&tochange=2bd127de1f05cd8379c279caea727690b847e5b9

2018-10-18T10:10:14: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=2bd127de1f05cd8379c279caea727690b847e5b9&full=1
2018-10-18T10:10:15: DEBUG : Found commit message:
Bug 1484496: Part 6 - Remove unused XPCOMUtils.IterSimpleEnumerator method. r=mccr8

	Andrei Oprea [:andreio]
	Comment 5 • 6 years ago

This was the previous bug 1421485 it was Chrome specific but we're seeing similar behaviour here.

	David Durst [:ddurst]
	Comment 6 • 6 years ago

Not sure if this is a simple thing or not, or if it's actually not newtab and instead the importer... feel free to move if appropriate.

	Tim Spurway [:tspurway]
	Comment 7 • 6 years ago

Sorry for the late reply on this, :ddurst!  

This is working as designed.

Frecency will not be calculated the same for history imported from other browsers.  For efficiency reasons, Firefox only imports the latest item for any site, rather than every visit.  The effect of this is that all sites imported will have the *same* frecency score.  Because top sites and highlights use frecency to decide what to display, the top sites and history all have the same actual weight, and will therefore not be in the same order.