Pete Moore [:pmoore][:pete] Assignee
	Description • 6 years ago

The README.md says that env var TASKCLUSTER_ROOT_URL is supported, but I believe not only is it supported but it is also required.

Furthermore, it would be useful to explicitly mention that the value 'https://taskcluster.net' should be used for the mozilla production environment.

	Pete Moore [:pmoore][:pete] Assignee
	Comment 1 • 6 years ago

Note, I've updated the docs to say TASKCLUSTER_ROOT_URL is required - can you confirm this is correct, and that it is not sufficient to just pass the root URL as a constructor argument?

If TASKCLUSTER_ROOT_URL is really required as an environment variable, I'll create a separate bug about changing that to a constructor argument, as it should be possible for a single python program to interface with two different taskcluster deployments from the same process.

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 2 • 6 years ago

Comment on attachment 9015257 [details] [review]
GitHub Pull Request for taskcluster-client.py

Thanks, Pete!

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 3 • 6 years ago

rootUrl is allowed as a constructor arg as well (just like clientId and accessToken).

Note that there will soon be multiple production deployments and we are working to make `https://taskcluster.net` *not* a working rootUrl (in the next 1-2 quarters), so including it in non-Mozilla-specific documentation is perhaps going to lead to confusion.

	Simon Fraser [:sfraser] ⌚️GMT
	Comment 4 • 6 years ago

Is it worth having the environment variable set on behalf of the people running tasks? So if a task is passed through the production taskcluster instance, the worker gets that environment variable. Otherwise, it's something that other groups will have to set in multiple places, and keep track of which is the right value under what conditions.

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 5 • 6 years ago

I think you mean having the variable set in a task?  Yes, that is in progress in bug 1460015.