Closed Bug 1495435 Opened 6 years ago Closed 6 years ago

`generic-worker install` shouldn't assume installation should use --configure-for-aws

Categories

(Taskcluster :: Workers, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmoore, Assigned: pmoore)

Details

Attachments

(1 file)

Currently, the generic-worker install target on Windows creates a run-generic-worker.bat script that runs generic-worker script with `--configure-for-aws` hardcoded. This should be a configurable setting when installing the worker.

Ideally the same syntax would be used in the install target as the run target, i.e.

`generic-worker install --configure-for-aws <other options>`

This is currently hardcoded here:

https://github.com/taskcluster/generic-worker/blob/3bfed74c7ed48e6db9b5ead1f75c0016fe2c7319/plat_windows.go#L396
Thanks John!
Assignee: nobody → pmoore
Attachment #9013339 - Flags: review?(jhford)
Attachment #9013339 - Flags: review?(jhford) → review+
Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/648b7d44755bbc8da5d68abf2f4b7a86a6b4da29
Bug 1495435 - Make --configure-for-aws a configurable option at install time

https://github.com/taskcluster/generic-worker/commit/e82c1e6c7dc290699d811b9f2f911e157904d8a5
Merge pull request #124 from taskcluster/bug1495435

Bug 1495435 - Make --configure-for-aws a configurable option at install time
Released in generic-worker 11.0.0.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Generic-Worker → Workers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: