Dustin J. Mitchell [:dustin] (he/him) Reporter
	Description • 6 years ago

16:45:02 <RyanVM> dustin: fresh attempt to cancel on m-r - " Taskcluster: A is undefined; can't access its "kind" property "

That was with
  https://queue.taskcluster.net/v1/task/Cs2saMAqTCO2erRCyQvgrg/runs/0/artifacts/public/actions.json
which indeed has no cancel action.  That should probably fail in a more helpful way :)

	Ed Morley [:emorley]
	Comment 1 • 6 years ago

Trying locally (unminifed), the error is:
`Taskcluster: action is undefined; can't access its "kind" property`

cancelTask ends up being undefined here:
https://github.com/mozilla/treeherder/blob/ecf4c4e33abf7abc5995a8b9f3bb811bc7c57087/ui/models/job.js#L157

...but still gets passed to TaskclusterModel.submit(). (I thought initially perhaps the change in bug 1492462 comment 3 affected this, but that only covered the "no actions.json at all" case)

I think more of the handling that's repeated for each type of workflow should be pushed down into TaskclusterModel, otherwise we'll have to add duplicate messaging for each of {retrigger, cancel, cancel-all, backfill, ...}.