Emil Ghitta, QA [:emilghitta] Reporter
	Description • 6 years ago

[Affected platforms]:
Ubuntu 18.04.

[Steps to reproduce]:
1. Launch an old Firefox Nightly (ex: One from 2018-09-13).
2. Update Firefox.

[Expected result]:
Firefox launches successfully.

[Actual result]:
Firefox crashes.

[Note]:
I didn’t managed to reproduce this issue on Windows or macOS.

Updated from 64.0a1 (2018-09-13) to latest Nightly
Crash Id:83707d06-80e4-4e3f-b48e-6a1190180917

Updated from 63.0b3 to latest Beta
Crash Id:f7a9e251-93aa-453b-a115-fdd530180917

Updated from 58.0.2 to 62.0 (not affected) 

Core dump: https://drive.google.com/open?id=1XPafpjBJs-2OIylsIQhecxloEPjS6Sl-

	Marcia Knous [:marcia]
	Comment 1 • 6 years ago

Is there a crash report in about:crashes?

	Alice0775 White
	Comment 2 • 6 years ago

> Updated from 64.0a1 (2018-09-13) to latest Nightly
> Crash Id:83707d06-80e4-4e3f-b48e-6a1190180917
> 
> Updated from 63.0b3 to latest Beta
> Crash Id:f7a9e251-93aa-453b-a115-fdd530180917


bp-83707d06-80e4-4e3f-b48e-6a1190180917

bp-f7a9e251-93aa-453b-a115-fdd530180917

	Emil Ghitta, QA [:emilghitta] Reporter
	Comment 3 • 6 years ago

Ups, my bad. Thanks Alice!

	Selena Deckelmann :selenamarie :selena
	Comment 4 • 6 years ago

I'm noticing that this crash is mostly affecting Thunderbird, but there's 70-ish for Firefox. Should we hand this over? Or is there something for us to look into? Thanks!

	Andrew Overholt [:overholt]
	Comment 5 • 6 years ago

(In reply to Alice0775 White from comment #2)
> bp-f7a9e251-93aa-453b-a115-fdd530180917

This crash seems VR-related. Maybe Daosheng has thoughts on the thread timeout (?) situation?

	Robert Strong (they/them - no direct email)
	Comment 6 • 6 years ago

(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #4)
> I'm noticing that this crash is mostly affecting Thunderbird, but there's
> 70-ish for Firefox. Should we hand this over? Or is there something for us
> to look into? Thanks!
It doesn't appear that there is anything for me to look into... there is nothing in the crash reports that indicate that this involves app update code and it appears to be a shutdown hang.

	Daosheng Mu[:daoshengmu]
	Comment 7 • 6 years ago

We recently refactor our VR thread model at Bug 1473397. It should be different than before. I will continue to seeing if anything needs to be changed as well once I am back on Fri.

	Daosheng Mu[:daoshengmu]
	Comment 8 • 6 years ago

MozReview-Commit-ID: HbWlMUQGXD8

	Daosheng Mu[:daoshengmu]
	Comment 9 • 6 years ago

I have given a fix for this issue. Besides, we are considering to remove VRListenerThread in FF64 for Bug 1494556. We will no longer see VRListenerThread be related with this shutdown hang issue.

	:kip (Kearwood Gilbert) Assignee
	Comment 10 • 6 years ago

Comment on attachment 9013008 [details]
Bug 1491868 - Avoid shutdown hang by checking if VRListenerThread is null.

:kip (Kearwood Gilbert) has approved the revision.

	Pulsebot
	Comment 11 • 6 years ago

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/a2e5b2b30bfa
Avoid shutdown hang by checking if VRListenerThread is null. r=kip

	Cristian Brindusan [:cbrindusan]
	Comment 12 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a2e5b2b30bfa

	Emil Ghitta, QA [:emilghitta] Reporter
	Comment 14 • 6 years ago

Hi Daosheng,

Unfortunately, Firefox still keeps on crashing after updating Firefox 64.0a1 bp-cc86dffb-db39-49d6-b156-30e940181005

	Daosheng Mu[:daoshengmu]
	Comment 15 • 6 years ago

That would be other issues because we have removed VRListenerThread at Bug 1494556.

	Daosheng Mu[:daoshengmu]
	Comment 16 • 6 years ago

At Bug 1494556, we have removed VRListenerThread. If it's still happened, that would be affected by other issues.

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 6 years ago

Bug 1494556 isn't going to be backported to 63.