Closed
Bug 1489040
Opened 6 years ago
Closed 6 years ago
WebRTC ICE candidate stats ipAddress needs to be renamed
Categories
(Core :: WebRTC, enhancement, P3)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: ng, Assigned: ng)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
It looks like the spec [0] is moving towards[1] the name 'address' instead of 'ip'. Either way things shake out we will need to rename 'ipAddress'[2]. [0] https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-ip [1] https://github.com/w3c/webrtc-pc/issues/1913 * [2] https://searchfox.org/mozilla-central/source/dom/webidl/RTCStatsReport.webidl#156 *Note the spec issue is filed against the webrtc-pc not webrtc-stats spec, but mentions the need to mirror the change in the webrtc-stats spec.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d083a377764c4409e1a06f80fa68549deefe00d
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4443f2ee1c51cc54b77eb1ba56b57579bd74f31
Assignee | ||
Comment 3•6 years ago
|
||
Bug 1489040 - P1 - Update WebRTC ICE candidate stats field ipAddress to new name, address Bug 1489040 - P2 - ajust WebRTC stats mochitest for new stat name 'address' Bug 1489040 - P3 - add test for legacy WebRTC stat names
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41107083a95a22eaf52385fca6c44108ee8b03f5
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b93ebdebffe6c888f497fc757932fa9d524534f7
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=956b5e9fcc605a0e3ceb08aba9cabf119f83a954
Comment 7•6 years ago
|
||
Comment on attachment 9008126 [details] Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.
Attachment #9008126 -
Flags: review+
Comment 8•6 years ago
|
||
Comment on attachment 9008126 [details] Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address Michael Froman [:mjf] has approved the revision.
Attachment #9008126 -
Flags: review+
Assignee | ||
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5795010a4a5ee776a1d1e8a0e69a8515503a3513
Assignee | ||
Comment 10•6 years ago
|
||
Spec Links for WebIDL review: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-address
Assignee | ||
Comment 11•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8ce4c69c850c5925e701ac8e5b3effaeb6fbd66
Comment 12•6 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/68d20ffd470d Update WebRTC ICE candidate stats field name ipAddress to address r=mjf,jib,smaug
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/68d20ffd470d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 14•5 years ago
|
||
Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/rtcicecandidatestats-has-been-updated-to-the-latest-spec/
Keywords: site-compat
Comment 15•5 years ago
|
||
Note to MDN writers: This is covered in the rel notes under the general note about RTCIceCandidateStats; see https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs I'm setting this to dev-doc-complete, because the other related bug (1324788) will cover this when the documentation is done.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•