Closed
Bug 1488241
Opened 6 years ago
Closed 6 years ago
Error link from about:support leads to about:policies#active instead of about:policies#errors
Categories
(Firefox :: Enterprise Policies, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | verified |
firefox64 | --- | verified |
People
(Reporter: emilghitta, Assigned: lschwalf, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
185.80 KB,
image/gif
|
Details | |
46 bytes,
text/x-phabricator-request
|
Felipe
:
review+
pascalc
:
approval-mozilla-beta+
|
Details | Review |
[Affected versions]: Firefox 63.0a1 (BuildId:20180903100454). [Affected platforms]: Windows 10 64bit. macOS 10.13.4 Ubuntu 16.04 64bit. [Preconditions]: Enter an invalid policy. [Steps to reproduce]: 1. Launch Firefox. 2. Access the about:support page. 3. Click the "Error" link from the "Enterprise Policies" section. [Expected result]: The about:policies#errors is displayed. [Actual result]: The about:policies#active is displayed. [Notes] For further information regarding this issue please observe the attached screencast.
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → lschwalfenberg
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9011123 [details] Bug 1488241 - Error link from about:support leads to about:policies#active instead of about:policies#errors. r?felipe :Felipe Gomes (needinfo me!) has approved the revision.
Attachment #9011123 -
Flags: review+
Comment 3•6 years ago
|
||
Thanks for your contribution, Luke! Can you fix the eslint error that showed up (missing semi-colon) and submit an updated patch? The code change is correct, so that's all that's missing. If you're are interested, there are two other good-first-bugs related to about:policies that we really would like that a new contributor picked up. They are: - Bug 1485109 - Simpler, but of higher importance - Bug 1488411 - Slightly more complex
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff4f20dd4858 Error link from about:support leads to about:policies#active instead of about:policies#errors. r=felipe
Updated•6 years ago
|
Priority: P5 → P1
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to :Felipe Gomes (needinfo me!) from comment #3) > Thanks for your contribution, Luke! Can you fix the eslint error that showed > up (missing semi-colon) and submit an updated patch? The code change is > correct, so that's all that's missing. > > If you're are interested, there are two other good-first-bugs related to > about:policies that we really would like that a new contributor picked up. > They are: > > - Bug 1485109 - Simpler, but of higher importance > - Bug 1488411 - Slightly more complex Thanks Felipe! Fixed the eslint error, and updated the change set. I'm looking forward to contributing more to Firefox. I might take a look at those other bugs at some point, but at the moment I'm ramping up to work with :paolo and my other UCOSP team members to work on updates we're making to "about:config". Cheers, Luke
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ff4f20dd4858
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 8•6 years ago
|
||
Comment on attachment 9011123 [details] Bug 1488241 - Error link from about:support leads to about:policies#active instead of about:policies#errors. r?felipe Approval Request Comment [Feature/Bug causing the regression]: about:policies [User impact if declined]: Link in about:support to about:policies is not ideal [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: QE will verify it [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: simple changing the link href [String changes made/needed]: none
Flags: needinfo?(felipc)
Attachment #9011123 -
Flags: approval-mozilla-beta?
Comment 9•6 years ago
|
||
Comment on attachment 9011123 [details] Bug 1488241 - Error link from about:support leads to about:policies#active instead of about:policies#errors. r?felipe Low risk patch for a P1 bug, uplift approved for 63 beta 10, thanks.
Attachment #9011123 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Reporter | ||
Comment 10•6 years ago
|
||
This issue is verified fixed using Firefox 64.0a1 (BuildId:20180924220042) on Windows 10 64bit, macOS 10.13.4 and Ubuntu 16.04 64bit.
Status: RESOLVED → VERIFIED
Comment 11•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e71d11110002
Reporter | ||
Comment 12•6 years ago
|
||
This issue is verified fixed using Firefox 63.0b10 (BuildId:20180927143327) on Windows 10 64bit, macOS 10.13.4 and Ubuntu 16.04 64bit. Thanks for fixing this!
You need to log in
before you can comment on or make changes to this bug.
Description
•