Shane Caraveo (:mixedpuppy) Assignee
	Description • 6 years ago

This is for the webext api side of the implementation.  backend is in bug 1486818

[1] https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/components/search/searchplugins/yandex-az.xml#14

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 3 • 6 years ago

Expanding this to include moz:* parameters and the pref capability.

	Dale Harvey (:daleharvey)
	Comment 4 • 6 years ago

    "name": "MozParamsTest",
    "search_url": "https://example.com/?q={searchTerms}",
    "params": [...mozParams, ...params],


Should this be "search_url_get_params" with a corresponding one for "suggest_url"? I havent found a case in which we use MozParams for suggest_url, so we could just encode the params in the url fields for plain 'Params' and use the params field only for MozParams. But that seems a little confusing

	Dale Harvey (:daleharvey)
	Comment 5 • 6 years ago

It seems like we dont support "search_url_post_params" to start with[1], we have some built in engines using POSTs @ https://searchfox.org/mozilla-central/source/browser/components/search/searchplugins/freelang.xml, will this need fixed or am I missing a different way to do these

[1] - https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/schemas/chrome_settings_overrides.json#69

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 6 • 6 years ago

(In reply to Dale Harvey (:daleharvey) from comment #4)
>     "name": "MozParamsTest",
>     "search_url": "https://example.com/?q={searchTerms}",
>     "params": [...mozParams, ...params],
> 
> 
> Should this be "search_url_get_params" with a corresponding one for
> "suggest_url"? I havent found a case in which we use MozParams for
> suggest_url, so we could just encode the params in the url fields for plain
> 'Params' and use the params field only for MozParams. But that seems a
> little confusing

These are not get params, or rather, they will work with either get or post.  I'll think about getting rid of the plain param as you suggested.

	Andrew Swan [:aswan]
	Comment 7 • 6 years ago

Comment on attachment 9004646 [details]
Bug 1486819 - support mozParams in webext search engines

Andrew Swan [:aswan] has approved the revision.

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 8 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b6de19df6e1686ce04455c5c62e695aa99efc4c

	Drew Willcoxon :adw
	Comment 9 • 6 years ago

Comment on attachment 9004646 [details]
Bug 1486819 - support mozParams in webext search engines

Drew Willcoxon :adw has approved the revision.

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 10 • 6 years ago

refactor some code into the search service.  This is necessary to
allow the searchservice to pull multiple locales or regions from a single
extension, based on data the searchservice maintains.

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 11 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6dded834725b75cea0134575ab319cf6cefa5a9e

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 12 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a406ab7a21deb05c206afb52970407c871d50a95

	Pulsebot
	Comment 13 • 6 years ago

Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1f268b2058c9
support mozParams in webext search engines r=aswan,adw,mkaply
https://hg.mozilla.org/integration/autoland/rev/47f1126313c6
move search engine specific logic into search service, r=mkaply

	Narcis Beleuzu [:NarcisB]
	Comment 14 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/1f268b2058c9
https://hg.mozilla.org/mozilla-central/rev/47f1126313c6

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 15 • 6 years ago

for dev-doc, specifically the suggest_url, suggest_url_post_params is now supported.  search_url_post_params was added in another bug as well.

I'm unsure if we want to document the param support on mdn or not as that is purely internal use, and only with builtin search extensions.

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 16 • 6 years ago

correction, the condition/purpose and pref params are internal only.  There are other params that are supported which map to some opensearch functionality and you can see that in the test file, but here they are:

+    {name: "simple", value: "5"},
+    {name: "term", value: "{searchTerms}"},
+    {name: "lang", value: "{language}"},
+    {name: "locale", value: "{moz:locale}"},

	Vlad Jiman
	Comment 17 • 6 years ago

Will this fix require manual validation? if so please provide some steps to help validate it or if it won't be necessary please set the flag 'qe-validate-'. Thank you

	Chris Mills [:cmills]
	Comment 18 • 6 years ago

Note to documentation team:

I've included a note in the Fx64 rel notes to cover this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#Changes_for_add-on_developers

Feel free to update this if you think it needs fixing up.

It looks like they are mentioned in the docs already too, but you should still check it out, and make sure browser compat data is updated, etc.

	Irene Smith
	Comment 19 • 6 years ago

Updated BCD and created a pull request: https://github.com/mdn/browser-compat-data/pull/3089