Simon Pieters [:zcorpan] Reporter
	Description • 6 years ago

See
https://github.com/whatwg/html/issues/3955
https://github.com/whatwg/html/pull/3934
https://github.com/web-platform-tests/wpt/pull/12640

	Mats Palmgren (inactive)
	Comment 1 • 6 years ago

The github issue seems to be leaning towards supporting it after all.
Which means we need to make list numbering work for fieldset/legend.

	Simon Pieters [:zcorpan] Reporter
	Comment 2 • 6 years ago

Yes, for legend, but not for fieldset.

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 3 • 6 years ago

Those arguments were added in bug 591737 to create a triangle for the
summary frame, but <summary> has been re-implemented by using "list-item"
since then. Now the only caller is nsBlockFrame itself, so there's no need
to expose those arguments.

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 4 • 6 years ago

The function was renamed in bug 1171419 Part 10.

Depends on D6839

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 5 • 6 years ago

nsCSSFrameConstructor::FindDisplayData() guarantees a block with "display:
list-item" will be constructed by ConstructBlock() (either through
ConstructScrollableBlock() or ConstructNonScrollableBlock()).

This is also a preparation to fix bug 1491915 since we want to control
bullet frame creation under column hierarchy.

Depends on D6840

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 6 • 6 years ago

Depends on D6841

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 7 • 6 years ago

Depends on D6842

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 8 • 6 years ago

I found this bug while doing the necessary refactoring for bug 1491915. I'll take a stab on this bug.

	Mats Palmgren (inactive)
	Comment 9 • 6 years ago

Comment on attachment 9011933 [details]
Bug 1486602 Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem()

Mats Palmgren (:mats) has approved the revision.

	Mats Palmgren (inactive)
	Comment 10 • 6 years ago

Comment on attachment 9011934 [details]
Bug 1486602 Part 2 - Replace RenumberLists with RenumberList in comments

Mats Palmgren (:mats) has approved the revision.

	Mats Palmgren (inactive)
	Comment 11 • 6 years ago

Comment on attachment 9011936 [details]
Bug 1486602 Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend

Mats Palmgren (:mats) has approved the revision.

	Mats Palmgren (inactive)
	Comment 12 • 6 years ago

Comment on attachment 9011937 [details]
Bug 1486602 Part 5 - Add a wpt test for legend list-item numbering, and update test expectations

Mats Palmgren (:mats) has approved the revision.

	Mats Palmgren (inactive)
	Comment 13 • 6 years ago

Comment on attachment 9011935 [details]
Bug 1486602 Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild()

Mats Palmgren (:mats) has approved the revision.

	Pulsebot
	Comment 14 • 6 years ago

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6674c998a39
Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem() r=mats
https://hg.mozilla.org/integration/autoland/rev/0923a919f70a
Part 2 - Replace RenumberLists with RenumberList in comments r=mats
https://hg.mozilla.org/integration/autoland/rev/8f4f56568e67
Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild() r=mats
https://hg.mozilla.org/integration/autoland/rev/99738159fdff
Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend r=mats
https://hg.mozilla.org/integration/autoland/rev/3856cee32a29
Part 5 - Add a wpt test for legend list-item numbering, and update test expectations r=mats

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 15 • 6 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13233 for changes under testing/web-platform/tests

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 16 • 6 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

	Eliza Balazs [:ebalazs_]
	Comment 17 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c6674c998a39
https://hg.mozilla.org/mozilla-central/rev/0923a919f70a
https://hg.mozilla.org/mozilla-central/rev/8f4f56568e67
https://hg.mozilla.org/mozilla-central/rev/99738159fdff
https://hg.mozilla.org/mozilla-central/rev/3856cee32a29

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 18 • 6 years ago

Upstream PR merged

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 19 • 6 years ago

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13233
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Xb1ZDe9WR2Kd1P4fNRhJnw)

	Chris Mills [:cmills]
	Comment 20 • 6 years ago

Note to docs team:

I've added a note to the Fx 64 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#CSS

I think Rachel Andrew did some updates on the compat data for this; that's probably all that's needed for the docs work, but it needs checking.