Closed Bug 1485893 Opened 6 years ago Closed 5 years ago

The text for an installed extension almost overlaps the "Disable Extension" button in about:preferences#home

Categories

(Firefox :: Settings UI, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox62 --- affected
firefox63 --- affected

People

(Reporter: obotisan, Unassigned, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css] )

Attachments

(2 files)

Attached image 3.png
[Affected versions]:
- Beta 62.0b19
- Nightly 63.0a1

[Affected platforms]:
- Windows 10 x64
- Windows 7 x64
- macOS 10.13
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Install an extension that overrides your homepage (e.g. https://addons.mozilla.org/en-US/firefox/addon/msn-homepage-bing-searchengine/).
2. Go to about:preferences#home.
3. Observe the "New Windows and Tabs" section.

[Expected result]:
- The text "An extension is controlling the page you see on new windows and home." and the button "Disable Extension" are correctly aligned.

[Actual result]:
- The text "An extension is controlling the page you see on new windows and home." and the button "Disable Extension" are almost overlapping.


[Regression range]:
- I will find the regression as soon as possible.

[Additional notes]:
- Please look at the attached image. 
- This issue is reproducing even in a maximized window.
This issue reproduces for extensions that have a longer name, like the one mentioned in comment 0.
Mentor: mconley
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [lang=css]
i have interest in patching the bug, my first bug.
(In reply to Ahmed Kadry from comment #2)
> i have interest in patching the bug, my first bug.

Hi, Ahmed! Thanks for volunteering! Do you have a build of Firefox ready to hack on?

If not, here are instructions on how to set up a build:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

Artifact builds are the quickest way of getting up and running, and additional instructions for using artifact builds can be found here:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds


Let me know at any point if you have any questions, and I'll do my best to help you out! It also helps to "needinfo" me, by clicking on the checkbox at the bottom of this page, and choosing "mentor" from the dropdown list - that adds your question to my queue, and ensures I don't lose track of it.
Assignee: nobody → ak.dev.business.360
Flags: needinfo?(ak.dev.business.360)
Thanks for accepting my request. I'm working on it.
I have patched the problem but can't have a build. I tried to build firefox from source but i build failed with no compiler warning 4 times, so what's next ? where to submit the batch for review.
thanks
Flags: needinfo?(ak.dev.business.360) → needinfo?(mconley)
Hi Ahmed,

Sorry for the delay, yesterday was a holiday in Canada.

Before submitting your patches for review, I highly recommend ensuring that they behave properly by getting your local build going. What operating system are you using? Have you tried following the steps I linked to in comment 3? If so, how far did you get?
Flags: needinfo?(mconley) → needinfo?(ak.dev.business.360)
Hi MR Mike,
greetings, no need for apologies, we are 7 time zones away

I tried to build Firefox on a 32-bit machine with Linux but hit a wall due to linker always runs out of address space, tried different configuration in mozconfig file but nothing works until finally find bug 1137346 at - 

 https://bugzilla.mozilla.org/show_bug.cgi?id=1137346 - which indicates that we can no longer build Firefox on 32-bit machines.

so i got a 64 bit machine and start preparing the environment, installing dependencies and other stuff and i hope to have successful build now.

thanks
Flags: needinfo?(ak.dev.business.360) → needinfo?(mconley)
(In reply to Ahmed Kadry from comment #7)
> so i got a 64 bit machine and start preparing the environment, installing
> dependencies and other stuff and i hope to have successful build now.
> 

Okay, great! Let me know if you have further difficulties in getting your build up and running.

Once you've verified that it works correctly, the instructions for submitting a patch for review can be found here:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Flags: needinfo?(mconley)

I am not sure if anyone is working on this. I would like to give it a shot.

Flags: needinfo?(jaws)

Hi trushita,

It doesn't appear as if u623256 ever came back with a patch for this, so sure - I think this bug is fair game for you to hack on!

The first step, however, is to ensure that this is in fact still a bug. It's possible that since the time this bug was filed, this has been fixed already. Can you repeat the steps-to-reproduce from comment 0 and post a screenshot of what about:preferences looks like? If the bug is still there, then we can proceed with producing a patch.

Flags: needinfo?(trushita)
Flags: needinfo?(jaws)
Assignee: u623256 → nobody
Attached image e.JPG

Disable button no more overlaps.

Flags: needinfo?(trushita)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #10)

Hi trushita,

It doesn't appear as if u623256 ever came back with a patch for this, so sure - I think this bug is fair game for you to hack on!

The first step, however, is to ensure that this is in fact still a bug. It's possible that since the time this bug was filed, this has been fixed already. Can you repeat the steps-to-reproduce from comment 0 and post a screenshot of what about:preferences looks like? If the bug is still there, then we can proceed with producing a patch.

I reproduced the issue and good to see its fixed! Attaching a screenshot.

Oana, can you confirm that this issue is fixed?

Flags: needinfo?(oana.botisan)

I checked on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64 using beta 67.0b18 and latest Nightly 68.0a1. I can't seem to reproduce the issue anymore. I think it's fixed.
One thing I've noticed is that I can't seem to install in Nightly the add-on from comment 0. I used another one to test on Nightly (Best Homepage Ever - New Tab Quick Launch (Free)).

Flags: needinfo?(oana.botisan)

Thanks!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: