Closed Bug 1485586 Opened 6 years ago Closed 3 years ago

The Edit button (" ... ") is barely visible if Dark Theme is active

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox62 --- affected
firefox63 --- affected

People

(Reporter: obotisan, Unassigned)

Details

Attachments

(1 file)

[Affected versions]:
- Beta 62.0b19
- Nightly 63.0a1

[Affected platforms]:
- Windows 10 x64
- Windows 7 x64
- macOS 10.13 


[Steps to reproduce]:
1. Enable Dark theme.
2. Select the last empty tile from Top Sites.
3. Press TAB from keyboards and observe the behaviour of the Edit button from the section beneath (to be more precise, the "..." button).

[Expected result]:
- It has a strong contrast color, maybe white like when it's active or a light grey.

[Actual result]:
- It's black on a dark grey color background and it's really hard to notice it. 
- It flashes white for a moment as you pass over it. 

[Regression range]:
- I don't know if it's a regression, but if it is I will find it as soon as possible. 

[Additional notes]:
- Please look at the attached gif.
- last good build: 2018-03-29
- first bad build: 2018-03-30
Mozregression concluded that Bug 1449792 - Add dark theme, thumbnail debounce and bug fixes to Activity Stream might by the cause for this issue. 

I don't think this is a regression. It's more that the background color changed in the dark theme and the color for the edit button still remained black and it produces very little contrast with the dark background.
Severity: enhancement → normal
Priority: -- → P3
Component: Activity Streams: Newtab → New Tab Page

With the proton and New Tab Page updates, the contrast with dark theme for the action buttons on tiles seems to have decent contrast (91.0a1 2021-07-05/ Win10, Mac 10.14). Closing as WFM.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: