Alexandru Simonca [:asimonca], Release Desktop QA Reporter
	Description • 6 years ago

[Affected versions]:
- Fx 62

[Affected platforms]:
- All 

[Steps to reproduce]:
1. Sign in to sync and access some websites to get some cookies.
2. Sync the account.
3. Open Firefox using a fresh profile.
4. Sign in to sync 
5. After syncing finishes, go to "about:preferences#sync" and press the "disconnect" button.
6. Check the "remove other private data" box and press "disconnect and delete".
7. Go to "about:preferences" and scroll down to "Cookies and site data" and press the "manage data" button.

[Expected result]:
- Cookies are removed

[Actual result]:
- Cookies are not removed.

[Regression range]:
- Not a regression. This is a new feature/

	Mark Hammond [:markh] [:mhammond]
	Comment 1 • 6 years ago

about:preferences#privacy -> "Clear History". Leave cookies selected, Time range set to "Everything", then hit "Clear Now". After this process many cookies remain.

Note that this bug was originally reported against Sync, but Sync just uses Sanitize.jsm. I subsequently verified the same behavior from "Clear History"

	:Gijs (he/him)
	Comment 2 • 6 years ago

This seems pretty important... Johann, are you able to look at this or do you need someone else to?

	:Gijs (he/him)
	Comment 3 • 6 years ago

Alexandru, given comment #1, are you able to determine a regression window?

	Alexandru Simonca [:asimonca], Release Desktop QA Reporter
	Comment 4 • 6 years ago

Sure thing. I'll get on it today.

	Johann Hofmann [:johannh]
	Comment 5 • 6 years ago

about:preferences#privacy -> "Clear History". Leave cookies selected, Time range set to "Everything", then hit "Clear Now". After this process many cookies remain.

How did you check "many cookies remain"? I can't reproduce this.

If you mean that other site data like localStorage or indexedDB remains, that's a known usability issue with the "Clear History" prompt, and we're planning to fix that eventually.

Then there's also the issue that you need to reload about:preferences to make clear history changes reflect in the site data manager, which will be fixed by bug 1460768.

	Mark Hammond [:markh] [:mhammond]
	Comment 6 • 6 years ago

(In reply to Johann Hofmann [:johannh] from comment #5)
> Then there's also the issue that you need to reload about:preferences to
> make clear history changes reflect in the site data manager, which will be
> fixed by bug 1460768.

Ah yes, that's what I saw - about:preferences#privacy -> "Clear History" to remove cookies, then went directly to "Manage Data" and I saw cookies remain. But refreshing about:preferences then going to "Manage Data" shows the cookies were infact removed.

Alexandru, can you please confirm that's the same issue you saw when originally reporting this? If so, I guess we can close this as a dupe of bug 1460768.

	Alexandru Simonca [:asimonca], Release Desktop QA Reporter
	Comment 7 • 6 years ago

(In reply to Mark Hammond [:markh] from comment #6)
> Ah yes, that's what I saw - about:preferences#privacy -> "Clear History" to
> remove cookies, then went directly to "Manage Data" and I saw cookies
> remain. But refreshing about:preferences then going to "Manage Data" shows
> the cookies were infact removed.


Yes, that's exactly how I did it as well. I didn't know about bug 1450768. I think it's a dupe, now, also. Thanks Johann for clearing that up.

	:Gijs (he/him)
	Comment 8 • 6 years ago

Thanks!