Closed
Bug 1481851
Opened 6 years ago
Closed 6 years ago
getStats: kind is missing from RTPStreamStats
Categories
(Core :: WebRTC, enhancement, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: fippo, Assigned: fippo)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
9.24 KB,
patch
|
ng
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
I renamed mediaType to kind in https://github.com/w3c/webrtc-stats/issues/301 and that is now missing from RTCRtpStreamStats. The old name will probably be around forever.
Assignee | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Rank: 25
Priority: -- → P3
Comment 2•6 years ago
|
||
WebIDL review information: The field in question is defined in the WebRTC Stats spec[0] on the RTCRtpStreamStats dictionary [1] The WebIDL changes confined to dom/webidl/RTCStatsReport.webidl [2] [0] https://w3c.github.io/webrtc-stats/ [1] https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats [2] https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/dom/webidl/RTCStatsReport.webidl#29
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8998547 -
Attachment is obsolete: true
Updated•6 years ago
|
Updated•6 years ago
|
Attachment #8998580 -
Flags: review?(na-g)
Comment 4•6 years ago
|
||
Comment on attachment 8998580 [details] [diff] [review] also adds (de)serialization for about:webrtc LGTM
Attachment #8998580 -
Flags: review?(na-g) → review+
Assignee | ||
Comment 5•6 years ago
|
||
smaug, can you please take a look from a webidl point of view? Can reupload to phabricator too if I missed the deadline.
Flags: needinfo?(bugs)
Updated•6 years ago
|
Flags: needinfo?(bugs)
Attachment #8998580 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/87b754ac0db0 Add kind to RTCRtpStreamStats as alias to mediaType. r=ng,smaug
Keywords: checkin-needed
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/87b754ac0db0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 8•6 years ago
|
||
Created a new page for RTCRtpStreamStats: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpStreamStats Added: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpStreamStats/kind The BCD data for this is added in PR #2802 on the BCD repo: https://github.com/mdn/browser-compat-data/pull/2802 I've also mentioned this on Firefox 63 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•