Ciprian Georgiu, Desktop QA Reporter
	Description • 6 years ago

[Affected versions]:
- latest Nightly 63.0a1
- Beta 62.0b13
- Release 61.0.1

[Affected platforms]:
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Launch Firefox on a clean profile (don't maximize the browser window).
2. Access `about:preferences` page and click on "Saved Logins..." button from the "Forms & Passwords" section.
3. Inspect the "Saved Logins..." dialog.

[Expected result]:
- The Search field and the "Logins for the following sites are stored on your computer" table does not appear cut off at the right side of the dialog.

[Actual result]:
- The Search filed appear cut off at the right side of the dialog, as well as the "Logins for the following sites are stored on your computer" table.

[Regression range]:
- Last good revision: 21c3fcf333f6931e6b18c3c2d169f6081b2af2e1
  First bad revision: b59a30cbdbff45fb037451761289bc8e11800945

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=21c3fcf333f6931e6b18c3c2d169f6081b2af2e1&tochange=b59a30cbdbff45fb037451761289bc8e11800945

[Additional notes]:
- this issue doesn't occur while Firefox is maximized
- it seems that the issue happens only if the dialog is resized to its minimum size
- see the attached screenshot

	Rares Doghi, Desktop QA
	Comment 1 • 6 years ago

Hi, I think the Layout component is a good place to start for this issue, please feel free to change the component if another is more appropriate.

	Sam Foster [:sfoster] (he/him)
	Comment 2 • 6 years ago

This is an annoying but doesnt break anything. Dao has pointed out a resolution to a possibly-similar issue in bug 1425724. I would be happy to mentor if anyone wants to take this on. You will need Ubuntu to test and verify a fix.

	Sahil Bhosale
	Comment 3 • 6 years ago

Can I get some more information related to this bug.

	Sam Foster [:sfoster] (he/him)
	Comment 4 • 6 years ago

(In reply to Sahil Bhosale from comment #3)
> Can I get some more information related to this bug.

It needs someone to:
* Observe and confirm the problem in Nightly on Ubuntu
* Investigate the cause - likely using the Browser Toolbox (see https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox ) Dao has suggested that the root cause for the content being cut off as described in comment 0 is similar to bug 1425724.
* Develop and propose a patch. 

You'll need to read bug 1425724 and the patch which fixed it, and study the CSS used in this screen and how it controls the column widths and wrapping (or not) of the content. 

To develop a patch you will need to be able to build firefox locally. A manifest build will be fine for this issue. If you have not already done this, follow the instructions on https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build/Linux_and_MacOS_build_preparation

I you have any questions at any point in this process, let me know - here on the bug, or via IRC in the #fxteam channel. We have a new worflow and tools for submitting patches. We you get to that point, I can help with that also.

	Sahil Bhosale
	Comment 5 • 6 years ago

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #0)
> Created attachment 8996987 [details]
> screenshot - issue.png
> 
> [Affected versions]:
> - latest Nightly 63.0a1
> - Beta 62.0b13
> - Release 61.0.1
> 
> [Affected platforms]:
> - Ubuntu 16.04 x64
> 
> [Steps to reproduce]:
> 1. Launch Firefox on a clean profile (don't maximize the browser window).
> 2. Access `about:preferences` page and click on "Saved Logins..." button
> from the "Forms & Passwords" section.
> 3. Inspect the "Saved Logins..." dialog.
> 
> [Expected result]:
> - The Search field and the "Logins for the following sites are stored on
> your computer" table does not appear cut off at the right side of the dialog.
> 
> [Actual result]:
> - The Search filed appear cut off at the right side of the dialog, as well
> as the "Logins for the following sites are stored on your computer" table.
> 
> [Regression range]:
> - Last good revision: 21c3fcf333f6931e6b18c3c2d169f6081b2af2e1
>   First bad revision: b59a30cbdbff45fb037451761289bc8e11800945
> 
> Pushlog:
> https://hg.mozilla.org/integration/autoland/
> pushloghtml?fromchange=21c3fcf333f6931e6b18c3c2d169f6081b2af2e1&tochange=b59a
> 30cbdbff45fb037451761289bc8e11800945
> 
> [Additional notes]:
> - this issue doesn't occur while Firefox is maximized
> - it seems that the issue happens only if the dialog is resized to its
> minimum size
> - see the attached screenshot

There is no such problem in my firefox nighty.

	Sahil Bhosale
	Comment 6 • 6 years ago

see this screenshot

	Dão Gottwald [:dao]
	Comment 7 • 6 years ago

Ciprian, can you reproduce this with a modern version of Ubuntu?

	Ciprian Georgiu, Desktop QA Reporter
	Comment 8 • 6 years ago

Yes, I can reproduce it on Ubuntu 18.04 x64 too.

Sahil, are you using a VM? try to resize the "Saved Logins..." dialog to its minimum size - please see the attached screencast.

	Sahil Bhosale
	Comment 9 • 6 years ago

Yes, the problem is there when we try to reduce the size of the "Saved login" dialog box while minimising the browser window. 

Some minor part of the text box at the right hand side gets hidden when we reduce it to a maximum extent. 

Can we use media queries here like if the size of the dialog box window reduces to a particular size we can assign a margin to the right side of the text field.

Is this possible in a web browser?

	Sam Foster [:sfoster] (he/him)
	Comment 10 • 6 years ago

(In reply to Sahil Bhosale from comment #9)
> Yes, the problem is there when we try to reduce the size of the "Saved
> login" dialog box while minimising the browser window. 
> 
> Some minor part of the text box at the right hand side gets hidden when we
> reduce it to a maximum extent. 
> 
> Can we use media queries here like if the size of the dialog box window
> reduces to a particular size we can assign a margin to the right side of the
> text field.
> 
> Is this possible in a web browser?

We could do a media query, but I'm not sure it is necessary. You can also "fix" the issue also by giving #filter a non-zero margin-right, but then it doesnt line up with the other right borders below. 

But, I'm looking at the markup at https://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/content/passwordManager.xul#70 and I don't think that hbox is doing anything except introducing a rounding error here. Can you try removing it - i.e. making textbox#filter a direct child of #savedsignons? You'll want to check the spacing around the #filter isn't changed. Ideally in all platforms, but if it checks out on your platform, post a patch and we can check on the others.

	Sahil Bhosale
	Comment 11 • 6 years ago

> But, I'm looking at the markup at
> https://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/
> content/passwordManager.xul#70 and I don't think that hbox is doing anything
> except introducing a rounding error here. Can you try removing it - i.e.
> making textbox#filter a direct child of #savedsignons? You'll want to check
> the spacing around the #filter isn't changed. Ideally in all platforms, but
> if it checks out on your platform, post a patch and we can check on the
> others.

Yes, I will try this and will see whether it will work or not.

	Pascal Chevrel:pascalc (PTO until April 26)
	Comment 12 • 6 years ago

Updating tracking flags as we get closer to the 64 release.

	TomS [:toms]
	Comment 13 • 5 years ago

Is this problem fixed? I can't reproduce this on the 65.0a1 nightly.