Closed
Bug 1478505
Opened 7 years ago
Closed 7 years ago
Add support for CSS prefers-reduced-motion media feature for Android
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
I think ANIMATOR_DURATION_SCALE is the corresponding setting.
https://developer.android.com/reference/android/provider/Settings.Global#ANIMATOR_DURATION_SCALE
Assignee | ||
Comment 1•7 years ago
|
||
CCing Android forks.
Note that this bug was filed in 'CSS Parsing and Computation', but all works for this should be done in widget/android and mobile/android.
Updated•7 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=796186ff46875c271ac9cb4035381433019e64e3
Detecting ANIMATOR_DURATION_SCALE changes depends on the machinery will be introduced in a patch for bug 1035774.
And an automation test for this will be introduced in bug 1486971.
Assignee | ||
Comment 3•7 years ago
|
||
D'oh! I did miss one place to change a variable name.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92f3d28812da14c621004793919d22735372fbc0
Assignee | ||
Comment 4•7 years ago
|
||
Hey jchen, there are two other settings relevant with animations on Android (in Developer options on my phone).
https://developer.android.com/reference/android/provider/Settings.Global.html#TRANSITION_ANIMATION_SCALE
https://developer.android.com/reference/android/provider/Settings.Global.html#WINDOW_ANIMATION_SCALE
It seems to me that those two settings are only for application windows, such as animation effects during switching applications, and not for the contents inside applications, right? Or should we check all three settings' values are 0?
Flags: needinfo?(nchen)
Comment 5•7 years ago
|
||
Right, I think it makes more sense to only check ANIMATOR_DURATION_SCALE.
Flags: needinfo?(nchen)
Assignee | ||
Comment 6•7 years ago
|
||
Great, thanks jchen. Though dependent bugs haven't landed yet, but those shouldn't affect this bug basically, so I will put patches for this bug on review now.
Assignee | ||
Comment 7•7 years ago
|
||
Because we are going to use it for prefers-reduced-motion media feature which
is tied to a system setting.
Assignee | ||
Comment 8•7 years ago
|
||
Depends on D5502
Assignee | ||
Comment 9•7 years ago
|
||
To make the test work properly, there needs two functions. One is just setting
a value for testing and sending the notificaiton for the value changes, the
other one is to reset the state for testing.
The test itself will be introduced in bug 1486971, especially in
https://phabricator.services.mozilla.com/D5004
Depends on D5503
Comment 10•7 years ago
|
||
Comment on attachment 9007969 [details]
Bug 1478505 - Rename GeckoInputDeviceListener to GeckoSystemStateListener. r=jchen
Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9007969 -
Flags: review+
Comment 11•7 years ago
|
||
Comment on attachment 9007970 [details]
Bug 1478505 - Implement prefers-reduced-motion on Android. r=jchen
Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9007970 -
Flags: review+
Comment 12•7 years ago
|
||
Comment on attachment 9007971 [details]
Bug 1478505 - Run test_mq_prefers_reduced_motion_dynamic.html on Android. r=jchen
Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9007971 -
Flags: review+
Comment 13•7 years ago
|
||
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/239fb18de868
Rename GeckoInputDeviceListener to GeckoSystemStateListener. r=jchen
https://hg.mozilla.org/integration/autoland/rev/aea09f709ef6
Implement prefers-reduced-motion on Android. r=jchen
https://hg.mozilla.org/integration/autoland/rev/759d828c5c2d
Run test_mq_prefers_reduced_motion_dynamic.html on Android. r=jchen
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/239fb18de868
https://hg.mozilla.org/mozilla-central/rev/aea09f709ef6
https://hg.mozilla.org/mozilla-central/rev/759d828c5c2d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•7 years ago
|
status-firefox63:
affected → ---
Comment 15•6 years ago
|
||
Documented — I've submitted a PR to update the compat data:
https://github.com/mdn/browser-compat-data/pull/3080
And added a note to the Fx64 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#CSS
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•