Paul Adenot (:padenot) Assignee
	Description • 6 years ago

      No description provided.

	Paul Adenot (:padenot) Assignee
	Comment 1 • 6 years ago

This changed in [0].

[0]: https://github.com/WebAudio/web-audio-api/pull/1359

	Paul Adenot (:padenot) Assignee
	Comment 2 • 6 years ago

Some background: https://github.com/WebAudio/web-audio-api/pull/1359#issuecomment-406036328

	Karl Tomlinson (:karlt)
	Comment 5 • 6 years ago
mozreview-review

Comment on attachment 8993084 [details]
Bug 1476695 - Update wpt expectations.

https://reviewboard.mozilla.org/r/257916/#review264912

::: testing/web-platform/meta/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html.ini:11
(Diff revision 1)
>    [# AUDIT TASK RUNNER FINISHED: 3 out of 3 tasks were failed.]
>      expected: FAIL
> +
> +  [# AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed.]
> +    expected: FAIL

Please remove the 3 out of 3 tasks were failed line as that has now been replaced.

https://bugzilla.mozilla.org/show_bug.cgi?id=1474463

	Karl Tomlinson (:karlt)
	Comment 6 • 6 years ago
mozreview-review

Comment on attachment 8993083 [details]
Bug 1476695 - Return minimum and maximum 32bits float for AudioParam.{minValue,maxValue} that used to return infinity.

https://reviewboard.mozilla.org/r/257914/#review264914

	Pulsebot
	Comment 9 • 6 years ago

Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/30f6da1b0aba
Return minimum and maximum 32bits float for AudioParam.{minValue,maxValue} that used to return infinity. r=karlt
https://hg.mozilla.org/integration/autoland/rev/1ae4395e7cf7
Update wpt expectations. r=karlt

	Cosmin Sabou [:CosminS]
	Comment 10 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/30f6da1b0aba
https://hg.mozilla.org/mozilla-central/rev/1ae4395e7cf7

	Eric Shepherd [:sheppy]
	Comment 11 • 6 years ago

Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode/offset
https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/value
https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/minValue
https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/maxValue

Also added a mention to Firefox 63 for developers.