Closed Bug 1476317 Opened 6 years ago Closed 6 years ago

Both "Disable For This Site" and "Enable For This Site" buttons are displayed

Categories

(Firefox :: Protections UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: ccomorasu, Assigned: johannh)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

[Affected versions]:
 Fx 63.0a2
 Fx 62.0b9

[Affected platforms]:
 Windows 10 x64
 mac OS 10.13
 Ubuntu 14.04 LTS x64

[Steps to reproduce]:
 1. Launch Firefox.
 2. From Hamburger Menu activate Tracking Protection.
 3. Open a website on two tabs.
 4. On the first tab deactivate Tracking Protection from the Privacy Panel.
 5. Go to the second tab.

[Expected result]:
 The Tracking Protection button states "Reload page".

[Actual result]:
 Both "Disable For This Site" and "Enable For This Site" buttons are displayed.

[Regression range]:
 Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3f8b00d17eea04f7849a42b855618b83c3409402&tochange=db11d8b0ea4651c00eed270420fda3b282c13ca7

[Additional notes]:
 Gif with the issue: https://imgur.com/a/l1YClOq
Has Regression Range: --- → yes
Has STR: --- → yes
Ah, not a great state indeed. It goes away if you reload the page but we should still fix it for 62...
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Component: Menus → Tracking Protection
Priority: -- → P1
(In reply to Cristian Comorasu [:ccomorasu], Release Desktop QA from comment #0)
> [Expected result]:
>  The Tracking Protection button states "Reload page".

I agree that this would be good to display, but considering that we want to uplift the fix to 62 (and we'd require new strings for this) and that we're changing this UI again soon anyway (which is when we can change this to say "Reload Page", I think), I'm going to just change the second tab to say the same thing as the first one.

Thanks for finding this!
Comment on attachment 8992970 [details]
Bug 1476317 - Fix identity popup display for pages with exceptions that have blocked content.

https://reviewboard.mozilla.org/r/257804/#review264730
Attachment #8992970 - Flags: review?(nhnt11) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/547dc7e730a7
Fix identity popup display for pages with exceptions that have blocked content. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/547dc7e730a7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I can confirm this issue is fixed, I verified using Fx 63.0a1, build ID: 20180722220044, on Windows 10 x64, Ubuntu 14.04 LTS and mac OS 10.13.5 beta.
Status: RESOLVED → VERIFIED
Just FYI, this'll need a rebased patch for Beta if the plan is to request uplift.
Flags: needinfo?(jhofmann)
The identity popup will now show that there's an exception on the site instead of being confused.

We previously didn't handle this state because I assumed it wouldn't be possible to enter.
Turns out if you open the same (tracking) site in two tabs and then add an exception in one tab,
the other tab will be in this state until reload.

MozReview-Commit-ID: GVVdNpsAm6h
Blocks: 1470020
Flags: needinfo?(jhofmann)
Comment on attachment 8998243 [details] [diff] [review]
Fix identity popup display for pages with exceptions that have blocked content

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1470020
[User impact if declined]: With some effort you can get a little broken identity popup
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: See comment 0
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Straightforward frontend patch that has baked in Nightly for a while and is covered with tests, only slight risk is that I needed to rebase a bunch of things for Beta, so we should make sure QA looks at it after uplift.
[String changes made/needed]: None
Attachment #8998243 - Flags: approval-mozilla-beta?
Comment on attachment 8998243 [details] [diff] [review]
Fix identity popup display for pages with exceptions that have blocked content

frontend fix for tracking protection, approved for 62.0b16
Attachment #8998243 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I can confirm this issue is fixed. I verified using Fx 62.0b16 on Windows 10 x64, mac OS 10.12 and Ubuntu 16.04 LTS.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: