Closed
Bug 1476289
Opened 6 years ago
Closed 5 years ago
[DevTools] - selected memory snapshot cleared when other snapshot is removed
Categories
(DevTools :: Memory, defect, P3)
DevTools
Memory
Tracking
(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 verified)
VERIFIED
FIXED
Firefox 65
People
(Reporter: cfogel, Assigned: sreeise, Mentored)
References
Details
(Keywords: polish, regression)
Attachments
(3 files)
[Affected versions]: - Firefox 61.0.1, 62.0b8, 63.0a1 (2018-07-17), 52.8.0esr, 60.0.2ESR [Affected platforms]: - WIN_10x64, Ubuntu 16.04LTS, macOS 10.13.4 [Steps to reproduce]: 1.Launch firefox; 2. Open devtools, select the memory tab; 3. Click the snapshot button multiple times (multiple snapshots listed); 4. Click on the last snapshot; 5. Click on the first snapshot's X button to remove form list. [Expected result]: - first snapshot is removed, selected snapshot remains selected [Actual result]: - selection is cleared [Regression range]: - mozregression bisection resulted: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1f16d3da9280e40ada252acf8110b91ee1edbb08&tochange=ae7413abfa4d3954a6a4ce7c1613a7100f367f9a last good: 1f16d3da9280e40ada252acf8110b91ee1edbb08 (2016-04-18) fhirst bad: ae7413abfa4d3954a6a4ce7c1613a7100f367f9a (2016-04-19) [Additional notes]: - attached screen recording with the issue;
Reporter | ||
Comment 1•6 years ago
|
||
Older versions did not have the [x] button at all, so it wasn't really an issue.
Reporter | ||
Updated•6 years ago
|
Keywords: regression
Updated•6 years ago
|
Priority: P5 → P2
Comment 3•6 years ago
|
||
I believe the fix is to call `event.stopPropagation()` in [1]. [1] https://searchfox.org/mozilla-central/rev/d160ac574a5798010eda4e33e91ee628aa268a33/devtools/client/memory/components/SnapshotListItem.js#95
Mentor: felash
Priority: P2 → P3
Updated•6 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → reeisesean
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•5 years ago
|
||
I meant to comment on this previously. Didn't see anyone working on this, hopefully this bug was ok to take. Adding stopPropagation did fix the issue with selected snapshots.
Pushed by jwajsberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9a3e8cf5260 Added event.stopPropagation to snapshot onClick delete function to prevent selected snapshot from being cleared from view r=julienw
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c9a3e8cf5260
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Updated•5 years ago
|
Flags: qe-verify+
Reporter | ||
Comment 8•5 years ago
|
||
Fix verified with 65.0b7 on win10 and macOS 10.13, 65.0b6 on Ubuntu18.04.
You need to log in
before you can comment on or make changes to this bug.
Description
•