Closed Bug 1476158 Opened 6 years ago Closed 6 years ago

Enable dom.animations-api.core.enabled by default

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

In bug 1471814 I have guarded all the stuff we are not ready to ship with separate prefs so we should now be able to turn on dom.animations-api.core.enabled in beta/release.

Specifically, enabling this gives us:

* Animation.ready/finished Promises (which should let us drop the polyfill
  introduced in bug 1449532)
* Animation.effect and the AnimationEffect/KeyframeEffect interfaces
  (i.e. ability to update keyframes / timing / target for animations in motion)
Putting this up for review now although I should allow another day at least for responses to the intent to ship before landing.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 8992820 [details]
Bug 1476158 - Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref;

https://reviewboard.mozilla.org/r/257658/#review264826
Attachment #8992820 - Flags: review?(bzbarsky) → review+
Comment on attachment 8992821 [details]
Bug 1476158 - Enable dom.animations-api.core.enabled on beta/release;

https://reviewboard.mozilla.org/r/257660/#review264828
Attachment #8992821 - Flags: review?(bzbarsky) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32f324bf03c0
Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref; r=bz
https://hg.mozilla.org/integration/autoland/rev/0b41f0b2c5b7
Enable dom.animations-api.core.enabled on beta/release; r=bz
https://hg.mozilla.org/mozilla-central/rev/32f324bf03c0
https://hg.mozilla.org/mozilla-central/rev/0b41f0b2c5b7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
I've submitted a PR against the browser compat database for this: https://github.com/mdn/browser-compat-data/pull/2650

I've also noted this change on Firefox 63 for developers.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: