Closed
Bug 1472792
Opened 6 years ago
Closed 6 years ago
Update actions spec to allow multiple actions with the same name, take the first one
Categories
(Taskcluster :: General, enhancement)
Taskcluster
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla63
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(2 files)
We allow multiple entries in actions.json to have the same name, but require that their contexts make them apply to disjoint sets of tasks. This is hard when you want a specific implementation for a few tasks, and a more general implementation for all other tasks. We have an "order" for actions already. So let's say that the first matching task, in order, is the one executed.
Assignee | ||
Comment 1•6 years ago
|
||
Once this is done, the two in-tree retriggers can both be named 'retrigger'.
Assignee | ||
Comment 2•6 years ago
|
||
Bug 1398277 needs a special retrigger action that applies only to decision tasks, with the default retrigger applying everywhere else.
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb5eab2f73acb4753c341d8a46253ff6d20abe69
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb284bcb99652799a87b927427f35c55be5fbc1d
Assignee | ||
Comment 5•6 years ago
|
||
Spec update: https://github.com/taskcluster/taskcluster-docs/pull/270
Assignee | ||
Comment 6•6 years ago
|
||
https://github.com/taskcluster/taskcluster-tools/pull/543
Assignee | ||
Comment 7•6 years ago
|
||
We'll need a similar thing for treeherder, too. /me smiles charmingly at Hassan..
Comment hidden (mozreview-request) |
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8990450 [details] Bug 1472792: give both retrigger actions the same name; https://reviewboard.mozilla.org/r/255524/#review262338
Attachment #8990450 -
Flags: review?(bstack) → review+
Assignee | ||
Comment 10•6 years ago
|
||
Huh, order isn't in the spec. https://github.com/taskcluster/taskcluster-references/blob/master/schemas/action-schema-v1.yml I think the in-tree stuff specifies an order for the array in actions.json. So I'll re-configure..
Assignee | ||
Comment 11•6 years ago
|
||
https://github.com/taskcluster/taskcluster-docs/pull/270 https://github.com/taskcluster/taskcluster-tools/pull/543 updated to just use the existing order, rather than the (nonexistent) order field.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8990450 -
Flags: review+ → review?(bstack)
Comment 13•6 years ago
|
||
mozreview-review |
Comment on attachment 8990450 [details] Bug 1472792: give both retrigger actions the same name; https://reviewboard.mozilla.org/r/255524/#review262606
Attachment #8990450 -
Flags: review?(bstack) → review+
Assignee | ||
Comment 14•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c6a04b45e71559ad5c8aecf6edab34be6398178
Comment 15•6 years ago
|
||
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools https://github.com/taskcluster/taskcluster-tools/commit/165e524561bef0ea92dc48552f89e62e21216cdf Bug 1472792 - select the lowest-ordered action of a given name (#543)
Comment 16•6 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/taskcluster-docs https://github.com/taskcluster/taskcluster-docs/commit/5bfe3777581aab38c09eb2b807c6d3dc5c0d128e Bug 1472792 - allow multiple actions with matching name This takes advantage of the order in which actions are specified in the array in `actions.json`. https://github.com/taskcluster/taskcluster-docs/commit/642465a01c2a7ae9309631861f147a158b332cd8 Merge pull request #270 from djmitche/bug1472792 Bug 1472792 - allow multiple actions with matching name, choose by order
Assignee | ||
Comment 17•6 years ago
|
||
OK, I think this needs to get implemented in treeherder, then we can land the mozilla-central patch. Hopefully that's a fairly small patch in TH. Over to you, Hassan!
Assignee: dustin → helfi92
Comment 18•6 years ago
|
||
Thanks for your work Dustin. I will try to send a PR sometime this week.
Status: NEW → ASSIGNED
Comment 19•6 years ago
|
||
Comment 20•6 years ago
|
||
This is now implemented in Treeherder via https://github.com/mozilla/treeherder/commit/4438b788f0c208e97743e470da7cb6e811c2a0b3.
Assignee: helfi92 → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 21•6 years ago
|
||
Awesome, thanks!
Assignee: nobody → dustin
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 22•6 years ago
|
||
I think this is deployed now, based on https://whatsdeployed.io/?owner=mozilla&repo=treeherder&name[]=Stage&url[]=https://treeherder.allizom.org/revision.txt&name[]=Prod&url[]=https://treeherder.mozilla.org/revision.txt
Assignee | ||
Comment 23•6 years ago
|
||
Whoops, I hadn't landed attachment 8990450 [details]. Landing it now with bug 1398277.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 24•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c20ba876af1c686aa454d8e8e216828df04216a Bug 1472792: give both retrigger actions the same name; r=bstack
Comment 25•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c20ba876af1
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Target Milestone: mozilla61 → mozilla63
Comment 26•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/4412639dcb7e
Comment 27•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/d2adfc87c259
You need to log in
before you can comment on or make changes to this bug.
Description
•