Closed
Bug 1472776
Opened 6 years ago
Closed 6 years ago
Implement a new 'cancel' action
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(firefox-esr60 fixed, firefox62 fixed, firefox63 fixed)
RESOLVED
FIXED
mozilla63
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(1 file)
This is similar to cancel-all. I think this can be generic. The best we can do to limit its effectiveness is limit the cancellation to tasks with schedulerId=gecko_level_L, and I don't see a big reason not to give generic hooks that permission.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
I think we eventually want to limit level 3 permissions to cancel, but it appears that we currently allow anyone to do that, so creating this action isn't a regression.
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8989243 [details] Bug 1472776: add a 'cancel' action to cancel one task; https://reviewboard.mozilla.org/r/254296/#review261332
Attachment #8989243 -
Flags: review?(mozilla) → review+
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06da5e793b2c add a 'cancel' action to cancel one task; r=tomprince
Comment 5•6 years ago
|
||
Backed out changeset 06da5e793b2c (bug 1472776) for linting failure on taskgraph/actions/cancel.py:12:1. Backout: https://hg.mozilla.org/integration/autoland/rev/e5b6f247a849108db472a6a10909a89dcbc6caa4 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=06da5e793b2c896f9d8ce7043c860ddd84231511&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=186237698&repo=autoland&lineNumber=273 <failure lines copied with some context, e.g. up to line with previous TEST-PASS>
Flags: needinfo?(dustin)
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=be764bc4969acbffe6d948d0683be1595fb44b54
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(dustin)
Comment hidden (mozreview-request) |
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ee86e691870 add a 'cancel' action to cancel one task; r=tomprince
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0ee86e691870
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 10•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/b640a344c574
status-firefox62:
--- → fixed
Comment 11•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/f815f353dd6b
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•