Closed Bug 1470568 Opened 6 years ago Closed 5 years ago

Stop supporting "rid=" in simulcast attributes once ESR doesn't serialize it anymore

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

60 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

      No description provided.
Summary: Stop supporting "pt=" and "rid=" in simulcast attributes once ESR doesn't serialize them anymore → Stop supporting "rid=" in simulcast attributes once ESR doesn't serialize it anymore
Rank: 25
Priority: -- → P3

It probably makes sense to do this before trying to implement the [[SendEncodings]] stuff from bug 1401592.

Blocks: 1401592
Assignee: nobody → docfaraday
Attachment #9097457 - Attachment description: Bug 1470568: Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. → Bug 1470568: Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. r?mjf
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fca72b71c56
Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. r=mjf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1586423

note, this seems to have broken meet.google.com -- see bug 1586423.

Since this is a breaking change for multiple conferencing services, we at the very least need a relnote for developers on this.

Keywords: dev-doc-needed

Updating the flag as per Bug 1586423.

We should probably reopen this bug since the change has been completely reverted.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

It sounds like meet and whereby are both working again here. I'm going to land this again.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c4bc326f3c7
Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. r=mjf
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED

Documentation notes: this is about removing attributes from the SDP used in simulcast which were only used in very old versions of the specification for simulcast. They were removed in version 4 of this specification: https://tools.ietf.org/html/draft-ietf-mmusic-sdp-simulcast-14

From a documentation perspective, this probably just needs a mention that connectivity with very older clients may no longer work until those are updated. We actually have no content at all on MDN yet about simulcast.

This regresses fippo's simulcast fiddle. https://jsfiddle.net/jib1/qcwe1t86/

Is this intentional? Is it salvageable?

Flags: needinfo?(drno)

You should be able to remove the "rid=" from that fiddle.

Flags: needinfo?(drno)

Noted on Firefox 72 for developers. We have no other documentation that covers this subject yet, so no further changes are needed.

No longer regressions: 1789908
Regressions: 1789908
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: