Closed
Bug 1470382
Opened 6 years ago
Closed 6 years ago
Visibility issues inside permission doorhanger on dark theme
Categories
(Firefox :: Site Identity, defect, P3)
Firefox
Site Identity
Tracking
()
VERIFIED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | wontfix |
firefox62 | --- | verified |
firefox63 | --- | verified |
People
(Reporter: asoncutean, Assigned: ntim)
References
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
johannh
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
[Affected versions]: - Firefox 61.0. - Firefox 62.0b2 - dev edition - Firefox 62.0a1 (2018-06-21) [Affected platforms]: - Mac OS 10.10 - Ubuntu 16.04 x64 - Windows 10 x64 [Steps to reproduce]: Precondtions : - If not on a Dev edition build, make sure to set the theme on dark from Menu-Customize-Themes. 1. Go to https://mozilla.github.io/webrtc-landing/gum_test.html 2. Click on the Screen button 3. Observe the Allow button 4. Select an option from Screen to share drop down form 5. Observe the warning message inside the yellow panel [Expected result]: - Step[3] and Step[6] - The texts are easy to distinguish. [Actual result]: - Step[3] and Step[6] - The texts are barely visible. [Additional Notes]: - Screenshot with the issue: (Allow button - https://drive.google.com/open?id=11U8paKuEAH8iQaFH00Io__CV474mJzDX ) and (warning message - https://drive.google.com/open?id=1ODyabvQxJrzOjSnfHlorvad-pLgqUHIp ) - The Allow button seems to look better on 61.0b1 dev edition : https://drive.google.com/open?id=1ZutiB_CiIPnYpDqQdp-ykKp9Va7beHtP
Reporter | ||
Updated•6 years ago
|
status-firefox60:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8993701 [details] Bug 1470382 - Fix visibility issues in WebRTC permission popup. https://reviewboard.mozilla.org/r/258386/#review265496
Attachment #8993701 -
Flags: review?(jhofmann) → review+
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9d2058cba30e Fix visibility issues in WebRTC permission popup. r=johannh
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9d2058cba30e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8993701 [details] Bug 1470382 - Fix visibility issues in WebRTC permission popup. Approval Request Comment [Feature/Bug causing the regression]: bug 1408121 [User impact if declined]: See comment 0 [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: see comment 0 [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: low risk [Why is the change risky/not risky?]: css only [String changes made/needed]: nope
Attachment #8993701 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Keywords: regression
Comment 6•6 years ago
|
||
Comment on attachment 8993701 [details] Bug 1470382 - Fix visibility issues in WebRTC permission popup. CSS fixes for better visibility, let's uplift for beta 12.
Attachment #8993701 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e84fba80aaa1
Updated•6 years ago
|
Flags: qe-verify+
Reporter | ||
Comment 8•6 years ago
|
||
The permission doorhanger looks good now on dark theme on Firefox 63.0a1 (2018-07-26) and Firefox 62.0b12 (20180726161819) under Windows 10 x64, macOS 10.12 and Ubuntu 16.04 x64. Note though, the screen share doorhanger broken UI as per bug 1406899 on Linux platform: https://drive.google.com/open?id=1pOw31WfFgFSm0fTyNohnFDxWckFGPeC0 .
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•