cmiller Reporter
	Description • 6 years ago

Update all files in socorro.external and their tests to run in Python 3 test runs.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 6 years ago

I'd rescope this to a specific subdirectory of socorro/external because that directory tree is huge. Perhaps socorro/external/rabbitmq/ first?

	[github robot]
	Comment 2 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/a8441d050041afe7b808775b71a57a073daec855
bug 1469718: all the changes for sub dir socorro.external.boto

In testing the raw dump data there was an error in the test value
returning as a binary string. This value was failing in comparison to
the expected unicode value for python 3. Placing print statements in
class level functions didn’t tell us much.So we traced the function from
top to bottom and bottom to top. This pushed over the deep end as we
found ourselves in the boto service source code. We couldn’t find the
exact time this conversion of the test value occurred. To solve this
issue we made the assumption data being used in raw dump is binary. So
we change the test value to be a binary string and also changed the
expected comparison to be a binary string as well. The implementation of
the function iteritems() changed from python 2 to 3. Similar to the
range function the change in implementation went from generating a list
to using an iterator. Lastly objects of type ‘dict_values’ is not JSON
serializable. To solve this we wrap the call to values with a call to
list.

https://github.com/mozilla-services/socorro/commit/09331004f0f808b0ca0f51c879fec91652699fa1
Merge pull request #4508 from ceddy-cedd/bug-1469718-Update-socorro.external

bug 1469718: all the changes for sub dir socorro.external.boto

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 6 years ago

Grabbing this to do soon.

Looks like the following are done now:

* socorro/unittest/external/boto/test_*.py
* socorro/unittest/external/es/test_*.py
* socorro/unittest/external/postgresql/test_*.py
* socorro/unittest/external/rabbitmq/test_*.py

Leaving this one:

* socorro/unittest/external/fs/test_*.py

	[github robot]
	Comment 6 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/4d9a8242b7c314518337b8ef2f7c6cfd3321349b
fix bug 1469718: convert socorro/external/crashstorage_base.py to Python 3

https://github.com/mozilla-services/socorro/commit/a56aaf70376a5c5bd255cd19f44d8252075e14f7
Merge pull request #4699 from willkg/1469718-crashstorage-base

fix bug 1469718: convert socorro/external/crashstorage_base.py to Python 3