Closed Bug 1467744 Opened 6 years ago Closed 6 years ago

Prefer XPCOMUtils.defineLazyGlobalGetters over Cu.importGlobalProperties in Marionette

Categories

(Remote Protocol :: Marionette, enhancement)

Product:
Remote Protocol
Component:
Marionette
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

Bug 1467744 - Lazily import globals in Marionette.
59 bytes, text/x-review-board-request
whimboo
: review+
Details 
Marionette makes use of Cu.importGlobalProperties, but according
to https://groups.google.com/forum/#!topic/mozilla.dev.platform/OaTIiB7eQV4
we should be lazily load it so it consumes less memory.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8984404 [details]
Bug 1467744 - Lazily import globals in Marionette.

https://reviewboard.mozilla.org/r/250234/#review256948

Great!
Attachment #8984404 - Flags: review?(hskupin) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9073960ee2c
Lazily import globals in Marionette. r=whimboo
https://hg.mozilla.org/mozilla-central/rev/a9073960ee2c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: