Pete Moore [:pmoore][:pete] Assignee
	Description • 6 years ago

This is a non-fatal error, but does cost 1 minute of time, and the cause should be investigated.

2018/06/04 18:23:05 Creating task feature Live Log...
2018/06/04 18:23:05 Creating task feature OS Groups...
2018/06/04 18:23:05 Creating task feature Mounts/Caches...
2018/06/04 18:23:05 Creating task feature Supersede...
2018/06/04 18:23:05 Starting task feature Live Log...
2018/06/04 18:24:05 Could not copy from backing log to livelog: io: read/write on closed pipe
2018/06/04 18:24:06 Starting task feature OS Groups...
2018/06/04 18:24:06 Starting task feature Mounts/Caches...
2018/06/04 18:24:06 Starting task feature Supersede...

	Pete Moore [:pmoore][:pete] Assignee
	Comment 1 • 6 years ago

Previously, we started the livelog process, and then polled the PUT port for up to one minute to wait for it to be active.

If the livelog process returns while we are waiting for the port to be active, we know something has gone wrong, and can immediately return an error, rather than waiting the full minute to return an error.

This change also tracks the command output from the livelog command, so that if the process does fail, we have the output from the command logged in the task's backing log which gets uploaded when the task is resolved.

	[github robot]
	Comment 2 • 6 years ago

Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/0d26028ac0b218a8541405cd09532a5c9e41595a
Bug 1466803 - If livelog process prematurely terminates, don't keep waiting for PUT port to become active

https://github.com/taskcluster/generic-worker/commit/0d64d1e01bb9dccfbe5fd2190a27678e277adb8e
Bug 1466803 - Go to great lengths to avoid bogus race detection issue

https://github.com/taskcluster/generic-worker/commit/c862752abde3b7b7a5f417967bff682da9ed0edf
Merge pull request #95 from taskcluster/bug1466803

Bug 1466803 - detect if livelog process terminates before PUT port is active

	Pete Moore [:pmoore][:pete] Assignee
	Comment 3 • 6 years ago

Released in https://github.com/taskcluster/generic-worker/releases/tag/v10.8.4