Closed
Bug 1465256
Opened 6 years ago
Closed 1 year ago
Remove the requirement to use the `browser‑style` class to apply browser styles when `browser_style` is `true`
Categories
(WebExtensions :: Frontend, defect, P3)
Tracking
(firefox-esr52 unaffected, firefox-esr60 affected, firefox61 affected, firefox62 affected, firefox63 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | affected |
| firefox61 | --- | affected |
| firefox62 | --- | affected |
| firefox63 | --- | affected |
People
(Reporter: e7358d9c, Unassigned)
References
Details
Due to bug 418833 and bug 1371951, `<input type="checkbox">` and `<input type="radio">` styles use `input[…] + label::before` selectors as a workaround. Rather than fixing the underlying issue, the developers fixing bug 1354336 instead choose to introduce the `browser-style` class. Once bug 1371951 is resolved, it will be possible to remove the `browser-style` style class requirement (i.e. revert d666bbb2097a¹) without introducing regressions. ¹ https://hg.mozilla.org/releases/mozilla-beta/rev/d666bbb2097a
(In reply to ExE Boss from comment #0) > Rather than fixing the underlying issue, the developers fixing > bug 1354336 instead chose to introduce the `browser-style` class. And then, instead of at least limiting the `browser-style` class requirement to just the `input[…] + label::before` selectors, chose to add said requirement to `<button>`, `<select>` and `<textarea>`, which were unaffected by bug 418833 and would’ve been just fine without it.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
status-firefox-esr52:
--- → unaffected
status-firefox61:
--- → affected
status-firefox62:
--- → affected
status-firefox63:
--- → affected
status-firefox-esr60:
--- → affected
OS: Unspecified → All
Hardware: Unspecified → All
The mentioned blockers are all closed by now, so it seems this could be resolved now?
Are the browser-style class workarounds no longer necessary? They are still documented as necessary on https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles
|
|
||
Updated•2 years ago
|
Severity: normal → S3
|
||
Comment 3•1 year ago
|
||
Closing bug because support for browser_style feature is going to be removed (at least in MV3), see bug 1827910.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•