Closed
Bug 1464349
Opened 6 years ago
Closed 6 years ago
The highlight card description overlaps the default size of the cell
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | wontfix |
firefox62 | --- | verified |
People
(Reporter: obotisan, Assigned: rrosario)
References
Details
(Keywords: regression)
Attachments
(1 file)
[Affected versions]: - Nightly 62.0a1 - beta 61.0b8 [Affected platforms]: - Windows 10 x64 - Ubuntu 16.04 x64 - macOS 10.13 [Steps to reproduce]: 1. Open any page (e.g. https://www.mozilla.org/en-US/firefox/60.0.1/firstrun/). 2. Open DevTools - Inspector 3. Right-click on any node and select "Screenshot Node". 4. Open a new tab and observe the Highlights section. [Expected result]: - The description is contained inside the default cell. [Actual result]: - The highlight card description overlaps the default size of the cell. [Regression range]: - last good: 2018-04-20 - first bad: 2018-04-21 - Mozregression concluded that Bug 1455216 - Add download Highlights, Highlights options and bug fixes to Activity Stream, might be the cause for this issue. [Additional notes]: - To see the issue access this link: https://drive.google.com/file/d/1qAfnEBP5uX_UtbRVjST-ZOEgjlD9P2pe/view?usp=sharing
Comment 1•6 years ago
|
||
Looks like it's trying to show a whole data uri as the source domain of the download.
Updated•6 years ago
|
Assignee: nobody → rrosario
Iteration: --- → 62.3 - Jun 18
Priority: -- → P2
Comment 2•6 years ago
|
||
Probably can just fix with `.card-host-name { white-space: nowrap }`
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/071fe796e3e0408421444285882fe2aca5b70b0f Fix Bug 1464349 - truncate and nowrap card hostnames https://github.com/mozilla/activity-stream/commit/8665636fcfbe4838ca657812ab841c1aa77e6933 Merge pull request #4176 from rlr/Bug1464349/nowrap Fix Bug 1464349 - truncate and nowrap card hostnames
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Iteration: 62.3 - Jun 18 → 62.2 - Jun 4
Updated•6 years ago
|
status-firefox-esr52:
--- → unaffected
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Comment 7•6 years ago
|
||
I have verified that the issue is no longer reproducible on the latest Nightly 62.0a1 (Build ID 20180604220149) on Windows 10 x64, Mac 10.13.3 and Arch Linux.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•