Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 6 years ago

Socorro keeps track of the first build id and report date for signatures in the "signatures" table. This is currently managed by alembic/sqlalchemy.

This bug covers moving that table to Django.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 6 years ago

While doing this, we should fix bug #1459215 as well, constrain the table by product, and fix the SignatureFirstDate API accordingly.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 6 years ago

I decided to WONTFIX bug #1459215. We can figure that out again later if we want to. It didn't seem used and no one is asking for it.

Things we need to do here:

1. create a Django model, Django migration, and Django model admin
2. write a data migration to copy from the old table to the new one
3. reimplement the UpdateSignaturesCronApp to update the new tables and the old tables
4. update tests and write any needed new ones

Push that out and verify the data got migrated correctly and UpdateSignaturesCronApp is updating data in both places.

4. reimplement the SignatureFirstDate API endpoint using the Django model and rip out all the related middleware bits
5. update top crashers to use the new stuff
6. update tests and write any needed new ones

Push that out and verify it's working.

7. fix UpdateSignaturesCronApp to only update the new table
8. update tests and write any needed new ones
9. write a migration to delete the old table

Push that out and verify it's working.

	[github robot]
	Comment 4 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/39fd20eb4d5943bbb6622c9a57f9a9b12b335c78
bug 1463121: add Signature Django model

This adds the Signature Django model, adds a Django model admin, adds a data
migration to copy everything from the old table to the new table, and
updates the UpdateSignatureScronApp to update both the old and new tables.

https://github.com/mozilla-services/socorro/commit/41eb7b077daf5ce76dd95d05584b7351cae22491
Merge pull request #4617 from willkg/1463121-signatures-1

bug 1463121: add Signature Django model (step 1)

	[github robot]
	Comment 6 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/d95393d103dd2152094c847a1ad6793ab2cc6e0e
bug 1463121: noop the data migration; create sql script

We had problems running the data migration because there was waaaay
more data in that table than I thought there was.

This noops the data migration in favor of a sql script ops will run
by hand.

https://github.com/mozilla-services/socorro/commit/1737e3f6dfb655658fffc67782eac3e5b565b720
Merge pull request #4620 from willkg/1463121-signatures-data-2

bug 1463121: noop the data migration; create sql script

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 9 • 6 years ago

Not sure why the autocloser didn't pick this up, but PR 4628 landed in:

https://github.com/mozilla-services/socorro/commit/65fe892cf9b8980979d044a34ef2221291fe1415

	[github robot]
	Comment 11 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/ea68b629489e7e6a3627a30b200ca342ecb10cdb
bug 1463121: Add row counts for non-pg tables to debug view

This will make it easier to verify that the crashstats_signature table
is growing at the same pace as the signatures table. Further, it shows
all the tables in the db so it'll surface other possible issues like whether
there are tables that shouldn't be there.

https://github.com/mozilla-services/socorro/commit/7da41ff29d7bf73ec67c3f124b212374b249ae6d
Merge pull request #4630 from willkg/1463121-debug-view

bug 1463121: Add row counts for non-pg tables to debug view

	[github robot]
	Comment 13 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/9caaef5d2a0242793eb1b141a89fe3cdb5617ab7
bug 1463121: fix debug view db table counts to work in stage

https://github.com/mozilla-services/socorro/commit/300824d427247613f9e4b151bcd5a6f7cbb14136
Merge pull request #4632 from willkg/1463121-fix-debug-view

bug 1463121: fix debug view db table counts to work in stage

	[github robot]
	Comment 14 • 6 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/22b4f3d1bf3e6b0420e3b9cb5f1b48d948f84bff
bug 1463121: reimplement consumers of signatures table

This reimplements the SignatureFirstDate API endpoint and the topcrashers
view to use the new Signature Django model.

https://github.com/mozilla-services/socorro/commit/58044515995e8d6afa10a1a4633ed64895820771
Merge pull request #4636 from willkg/1463121-signature-step-2

bug 1463121: signature step 2

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 16 • 6 years ago

I verified step 2 on stage. Everything looks good so far.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 17 • 6 years ago

I created a new bug to delete tables. Marking this one as FIXED.