Closed
Bug 1463085
Opened 6 years ago
Closed 6 years ago
Possibly unnecessary self-assign in testing/marionette/listener.js
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: standard8, Assigned: ato)
References
Details
Attachments
(1 file)
This is being picked up by ESLint 5 which we haven't got in the tree yet, but I'm testing out the early versions. testing/marionette/listener.js 1154:22 error 'opts.startNode' is assigned to itself. no-self-assign (eslint) Coming from here: https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/testing/marionette/listener.js#1154 This code was last changed by bug 1400256 and it looks like it might now be an unnecessary assignment, but I'm not totally sure.
Flags: needinfo?(ato)
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•6 years ago
|
||
This is a leftover from when we used to have to deserialise the web element passed from chrome space ourselves.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Flags: needinfo?(ato)
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979212 [details] Bug 1463085 - Remove unnecessary self-assignment. https://reviewboard.mozilla.org/r/245442/#review251940
Attachment #8979212 -
Flags: review?(mjzffr) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/032d683ed7e7 Remove unnecessary self-assignment. r=maja_zf
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/032d683ed7e7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•