Closed Bug 1461589 Opened 6 years ago Closed 2 years ago

implement font-variant-emoji

Categories

(Core :: Graphics: Text, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: heycam, Assigned: jfkthame)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete, Whiteboard: [gfx-noted], [wptsync upstream])

Attachments

(4 files)

      No description provided.
Whiteboard: [gfx-noted]

See https://github.com/googlefonts/noto-emoji/issues/391 for an example of a situation where this is wanted.

And see https://github.com/w3c/csswg-drafts/issues/7315 for a spec question that we should get clarified before shipping this.

I have some WIP here, but I'd like to get a response to #7315 before moving forward as that may require changes to the behavior currently implemented by these patches.

Assignee: nobody → jfkthame
Attachment #9278445 - Attachment description: WIP: Bug 1461589 - Add support for the CSS font-variant-emoji property to the style system. → Bug 1461589 - Add support for the CSS font-variant-emoji property to the style system. r=#firefox-style-system-reviewers
Status: NEW → ASSIGNED
Attachment #9278446 - Attachment description: WIP: Bug 1461589 - Handle font-variant-emoji during font matching. → Bug 1461589 - Handle font-variant-emoji during font matching. r=#layout-reviewers
Attachment #9278447 - Attachment description: WIP: Bug 1461589 - Add/update tests to cover font-variant-emoji. → Bug 1461589 - Add/update tests to cover font-variant-emoji. r=#layout-reviewers
Severity: normal → S3
Attachment #9278447 - Attachment description: Bug 1461589 - Add/update tests to cover font-variant-emoji. r=#layout-reviewers → Bug 1461589 - Add/update CSS parsing tests to cover font-variant-emoji. r=#layout-reviewers

These tests assume the system has both text- and emoji-style glyphs available for U+263A, the old WHITE SMILING FACE
symbol that has long existed in legacy fonts, and now also supports an emoji-style rendering. If two distinct
presentations are not available, the first (mismatch) test will fail.

The spec says:

Even when font-variant-emoji is used, the presence of Variation Selector 15 (U+FE0E) or Variation Selector 16 (U+FE0F)
in the contents of an element override the rendering specified in font-variant-emoji.
Therefore, font-variant-emoji sets a default presentation which the text being rendered can opt out of.

So the second test checks that U+263A responds to the property as expected, and that the variation selectors
can still override it.

Depends on D147496

Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39eda9a47424
Add support for the CSS font-variant-emoji property to the style system. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c44d30da26ef
Handle font-variant-emoji during font matching. r=emilio
https://hg.mozilla.org/integration/autoland/rev/98090ae94c2f
Add/update CSS parsing tests to cover font-variant-emoji. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/c1a7287807c1
Add a WPT reftest for text/emoji-style presentation controls. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36611 for changes under testing/web-platform/tests
Whiteboard: [gfx-noted] → [gfx-noted], [wptsync upstream]
Regressions: 1796983
Regressions: 1796985
Upstream PR merged by moz-wptsync-bot
Regressions: 1797915

FF108 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/22118

Completed documenting this property.

Related Pull Requests:

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: