Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Description • 6 years ago

It would be very useful for investigation connection failures for geckodriver during startup when we would know the port number of Marionette geckodriver tries to connect to. 

One of those examples can be found here:
https://stackoverflow.com/questions/50314802/org-openqa-selenium-webdriverexception-connection-refused-while-using-selenium

> 1526203737341   geckodriver     INFO    geckodriver 0.20.1
> 1526203737367   geckodriver     INFO    Listening on 127.0.0.1:25016
> 1526203737796   mozrunner::runner       INFO    Running command: "/usr/bin/firefox-bin" "-marionette" "-profile" "/tmp/rust_mozprofile.ESuH8rdqpwT8"
> 1526203737802   geckodriver::marionette DEBUG   Waiting 60s to connect to browser
> 1526203739872   Marionette      INFO    Listening on port 2828
> 1526203797867   webdriver::server       DEBUG   <- 500 Internal Server Error {"value":{"error":"unknown error","message":"connection refused","stacktrace":""}}
> 11:29:57.944 [pool-2-thread-1] ERROR test.Test - Exception occured while processing.
> org.openqa.selenium.WebDriverException: connection refused

Here it's not clear why the connection failed. Marionette clearly created the socket listener on port 2828 but geckodriver failed to connect. I feel that it tries to a random port but somehow the hard-coded port 2828 is used via the profile.

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8975415 [details]
Bug 1461270 - [geckdriver] Log Marionette host and port.

https://reviewboard.mozilla.org/r/243710/#review249604

::: commit-message-87cc1:1
(Diff revision 1)
> +Bug 1461270 - [geckdriver] Log host and port of Marionette to connect to.

Maybe “Log Marionette host and port” would suffice?

::: testing/geckodriver/src/marionette.rs:1345
(Diff revision 1)
> -        debug!("Waiting {}s to connect to browser", timeout.as_secs());
> +        debug!("Waiting {}s to connect to browser on {}:{}",
> +               timeout.as_secs(), DEFAULT_HOST, self.port);

I don’t necessarily think this is what rustfmt expects, but OK.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 3 • 6 years ago
mozreview-review-reply

Comment on attachment 8975415 [details]
Bug 1461270 - [geckdriver] Log Marionette host and port.

https://reviewboard.mozilla.org/r/243710/#review249604

> I don’t necessarily think this is what rustfmt expects, but OK.

Good idea. I will run it through rustfmt.

	Pulsebot
	Comment 5 • 6 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fa45897c5eb
[geckdriver] Log Marionette host and port. r=ato

	Cosmin Sabou [:CosminS]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5fa45897c5eb