Iulia Cristescu, QA [:JuliaC] (away, please needinfo? cornel.ionce@softvision.ro) Reporter
	Description • 6 years ago

[Affected versions]:
- 61.0b4 build1 (20180510160705)

[Affected platforms]:
- Windows 10 x54
- macOS 10.13.3
- Ubuntu 16.04 x86

[Preconditions]
- You need access to SHIELD Control Panel ( https://normandy-admin.stage.mozaws.net/ )
- Set the 'app.normandy.dev_mode' preference to 'true' to run recipes immediately on startup.
- Set the 'app.normandy.logging.level' preference to '0' to enable more logging.
- Set the 'security.content.signature.root_hash' preference to 'DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90'.
- Set the preference value for 'app.normandy.api_url' to 'https://normandy.stage.mozaws.net/api/v1'.

[Steps to reproduce]:
1. Open the SHIELD Control Panel.
2. Create, approve and publish a new opt-out-study recipe (or a new pref-experiment recipe)(use the following filter normandy.channel == 'nightly')
3. Launch latest Firefox Nightly version having the pre-requisites set.
4. Close Firefox Nightly version and open latest Firefox Beta version using the same profile.
5. Open the browser console. 

[Expected result]:
- No telemetry errors are thrown 

[Actual result]:
- TelemetryStopwatch errors are thrown after opening Firefox Beta 
- See the screenshot https://drive.google.com/file/d/19ysm4gG1n76HBZxlvEfyxr47Y--kajXg/view?usp=sharing

[Regression range]:
- I will provide more details as soon as possible 

[Additional notes]:
- This issue is sometimes reproducible without being necessary a channel downgrade (just need to launch Firefox having the pre-requisites set)

	Georg Fritzsche [:gfritzsche]
	Comment 1 • 6 years ago

We need to investigate at least whether that impacts anything or is just a race.
P2 for investigating in the next iteration.

	Chris H-C :chutten Assignee
	Comment 2 • 6 years ago

Let's just remove TELEMETRY_PENDING_LOAD_MS. We have not ever looked at it.

	Chris H-C :chutten Assignee
	Comment 3 • 6 years ago

We introduced these measures in bug 1033860 because of the variety of different
things besides pings we were sending using Telemetry. We don't do that any more
and haven't looked at these probes in at least two years.

	Phabricator Automation
	Comment 4 • 6 years ago

Comment on attachment 8990420 [details]
bug 1460900 - Cease timing how long it takes to load pings from disk r?janerik

Jan-Erik Rediger [:janerik] has approved the revision.

https://phabricator.services.mozilla.com/D2008

	Pulsebot
	Comment 5 • 6 years ago

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9912325cd073
Cease timing how long it takes to load pings from disk r=janerik

	Raul Gurzau (:RaulG)
	Comment 6 • 6 years ago

Backed out changeset 9912325cd073 (bug 1460900) for Linting failure on gecko/toolkit/components/telemetry/TelemetryStorage.jsm on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/186c6e9d0b9e187c6bbbf4033b0a33fd24cb6d0a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9912325cd0737296ecdd10d4cfc810bcafcd519d

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=187178245&repo=autoland&lineNumber=269

Log snippet: 
[vcs 2018-07-09T15:26:10.948Z] 245510 files updated, 0 files merged, 0 files removed, 0 files unresolved
[vcs 2018-07-09T15:26:11.182Z] updated to 9912325cd0737296ecdd10d4cfc810bcafcd519d
[vcs 2018-07-09T15:26:11.194Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["c3.xlarge"], "lowerIsBetter": true, "name": "clone", "shouldAlert": false, "subtests": [], "value": 116.34411978721619}, {"extraOptions": ["c3.xlarge"], "lowerIsBetter": true, "name": "pull", "shouldAlert": false, "subtests": [], "value": 8.578593015670776}, {"extraOptions": ["c3.xlarge"], "lowerIsBetter": true, "name": "update", "shouldAlert": false, "subtests": [], "value": 100.55352091789246}, {"extraOptions": ["c3.xlarge"], "lowerIsBetter": true, "name": "overall", "shouldAlert": false, "subtests": [], "value": 226.38981199264526}]}
[vcs 2018-07-09T15:26:11.548Z] TinderboxPrint:<a href=https://hg.mozilla.org/integration/autoland/rev/9912325cd0737296ecdd10d4cfc810bcafcd519d title='Built from autoland revision 9912325cd0737296ecdd10d4cfc810bcafcd519d'>9912325cd0737296ecdd10d4cfc810bcafcd519d</a>
[task 2018-07-09T15:26:11.548Z] executing ['bash', '-cx', 'cd /builds/worker/checkouts/gecko/ && cp -r /build/node_modules_eslint node_modules && ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules && ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules && ./mach lint -l eslint -f treeherder --quiet\n']
[task 2018-07-09T15:26:11.556Z] + cd /builds/worker/checkouts/gecko/
[task 2018-07-09T15:26:11.556Z] + cp -r /build/node_modules_eslint node_modules
[task 2018-07-09T15:26:12.062Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2018-07-09T15:26:12.063Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2018-07-09T15:26:12.064Z] + ./mach lint -l eslint -f treeherder --quiet
[task 2018-07-09T15:26:12.752Z] New python executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python2.7
[task 2018-07-09T15:26:12.752Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python
[task 2018-07-09T15:26:14.307Z] Installing setuptools, pip, wheel...done.
[task 2018-07-09T15:26:15.399Z] running build_ext
[task 2018-07-09T15:26:15.399Z] building 'psutil._psutil_linux' extension
[task 2018-07-09T15:26:15.399Z] creating build
[task 2018-07-09T15:26:15.399Z] creating build/temp.linux-x86_64-2.7
[task 2018-07-09T15:26:15.399Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2018-07-09T15:26:15.399Z] creating build/lib.linux-x86_64-2.7
[task 2018-07-09T15:26:15.399Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2018-07-09T15:26:15.399Z] building 'psutil._psutil_posix' extension
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-07-09T15:26:15.399Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2018-07-09T15:26:15.399Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-07-09T15:26:15.399Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-07-09T15:26:15.399Z] 
[task 2018-07-09T15:26:15.399Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-07-09T15:31:09.428Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/components/telemetry/TelemetryStorage.jsm:681:9 | 'idAsObject' is assigned a value but never used. (no-unused-vars)

	Pulsebot
	Comment 7 • 6 years ago

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dea772389903
Cease timing how long it takes to load pings from disk r=janerik

	Chris H-C :chutten Assignee
	Comment 8 • 6 years ago

Should've caught it locally, but missed it. Trivial amendment pushed.

	Andrei Ciure[:aciure]
	Comment 9 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/dea772389903

	Adrian Florinescu [:aflorinescu]
	Comment 10 • 6 years ago

Running an add-on study type recipe, downgrading from 64.0a1 to 63.0b13, I couldn't spot the TelemetryStopwatch error in the browser console. Based on the above, marking as verified.