Closed Bug 1460876 Opened 6 years ago Closed 4 years ago

[Twitch] Text overlapping inside the Following page

Categories

(Core :: Layout: Text and Fonts, defect, P3)

defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox60 --- affected
firefox61 --- affected
firefox62 --- affected
firefox73 --- unaffected
firefox74 --- unaffected
firefox75 --- unaffected

People

(Reporter: asoncutean, Unassigned)

References

Details

Attachments

(1 file)

[Affected versions]: 
- 60.0 (20180503143129)
- 61.0b4 (20180510160705)
- 62.0a1 (2018-05-11)

[Affected platforms]:
- Ubuntu 16.04 x64
- Mac OS 10.12
- Windows 10 x86

[Steps to reproduce]:
Prerequisites:
- Make sure to have some watched history videos 

1. Log in on https://www.twitch.tv/
2. Click on the ‘Following’ button (https://www.twitch.tv/directory/following)
3. Observe the text below the videos in the ‘Latest video’ section

[Expected result]:
- The date is not overlapping the title description of any video.

[Actual result]:
- The date is overlapping the title description for some of the videos.

[Regression range]:
- I will try to determine one asap.
I was able to restrain the regression range to the following:

- Last good revision: 22f51211915bf7daff076180847a7140d35aa353 (2016-01-01)
- First bad revision: ce643acfab14d95bea2fb6c4f56477413514b686 (2016-01-02)
- Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=22f51211915bf7daff076180847a7140d35aa353&tochange=ce643acfab14d95bea2fb6c4f56477413514b686


I encountered a strange behavior, while searching the regression range. For some builds (I didn't see a pattern, this happened only on few occasions, on old builds, as well on the new ones), the “Latest video” section is displayed differently, with the date displayed on the video thumbnail ( https://drive.google.com/open?id=1zwjvDrbMMfXf0ffT_xkz1DX9So1tOCR6 ). If then retry to open the same builds, the “Latest video” section appears like in bug description (with the date displayed under the video text description - https://drive.google.com/open?id=11aHDoMJgGBNPW1DVSxBsCyNccSF_mBuX ). Not sure why this inconsistency appears and what should be the correct interpretation of the browser, note than  on Chromium/Chrome, the section in question is displayed with the date below the video text description.
Flags: needinfo?(miket)
This is a -webkit-line-clamp issue:

.video-preview-card__video-title {
    color: #19171c;
    min-height: 2rem;
    max-height: 4rem;
    display: -webkit-box;
    -webkit-line-clamp: 2;
    -webkit-box-orient: vertical;
}

They're relying on that to prevent the overlap.
Flags: needinfo?(miket)
(removing regression keyword, because we never supported this)
Keywords: regression
Priority: -- → P3

Hi Anca, can you please check if the twitch website has changed?

I have history of videos watched but when visiting "following", there is no "Latest videos" section.

If you don't mind attaching a video that would be great. I've tested this using Firefox Nightly version 75.0a1 (2020-02-12) (64-bit), Beta 74.0b2 (64-bit) and Release 73.0 (64-bit) for windows 10 pro and I’m not able to reproduce the issue. Based on this I will mark each respective flag as unaffected for now.

Best,
Clara

Flags: needinfo?(anca.soncutean)

(In reply to Clara Guerrero from comment #4)

Hi Anca, can you please check if the twitch website has changed?
I have history of videos watched but when visiting "following", there is no "Latest videos" section.

Apparently, there are some changes here, site related, I can no longer see any dates displayed below videos from "Latest videos" section, using the same account I've used when this issue was submitted. Taking this into account, this issue is no longer a valid one.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(anca.soncutean)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: