Emilio Cobos Álvarez (:emilio) Assignee
	Description • 6 years ago

      No description provided.

	Xidorn Quan [:xidorn] UTC+11
	Comment 3 • 6 years ago
mozreview-review

Comment on attachment 8974749 [details]
Bug 1460655: Make resolutions more like the rest of the CSS values.

https://reviewboard.mozilla.org/r/243130/#review249068

	Xidorn Quan [:xidorn] UTC+11
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8974749 [details]
Bug 1460655: Make resolutions more like the rest of the CSS values.

https://reviewboard.mozilla.org/r/243130/#review249070

::: servo/components/style/values/specified/resolution.rs:60
(Diff revision 1)
> +        if value <= 0. {
> +            return Err(location.new_custom_error(StyleParseErrorKind::UnspecifiedError));
> +        }

Could you file a followup to remove this condition if there isn't one already?

This seems wrong to exclude zero from a number type. Also the spec seems to allow negative for resolution (it just always resolves to false, but should still parse).

	Xidorn Quan [:xidorn] UTC+11
	Comment 5 • 6 years ago
mozreview-review

Comment on attachment 8974750 [details]
Bug 1460655: Support x as a resolution unit.

https://reviewboard.mozilla.org/r/243132/#review249072

::: layout/style/test/test_media_queries.html:562
(Diff revision 1)
> +    expression_should_be_parseable(feature + ": 1.5x");
>      expression_should_be_parseable(feature + ": 2.0dppx");
>      expression_should_not_be_parseable(feature + ": 0dpi");
>      expression_should_not_be_parseable(feature + ": -3dpi");
>      expression_should_not_be_parseable(feature + ": 0dppx");
> +    expression_should_not_be_parseable(feature + ": 0dppx");

I suppose you mean `0x` here.

	Pulsebot
	Comment 8 • 6 years ago

Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f04aa80db6d0
Make resolutions more like the rest of the CSS values. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/30f281e6cd1f
Support x as a resolution unit. r=xidorn

	Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)
	Comment 9 • 6 years ago

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10969 for changes under testing/web-platform/tests

	Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)
	Comment 10 • 6 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f04aa80db6d0
https://hg.mozilla.org/mozilla-central/rev/30f281e6cd1f

	Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)
	Comment 12 • 6 years ago

Upstream PR merged

	Will Bamberg [:wbamberg]
	Comment 13 • 6 years ago

I've updated https://developer.mozilla.org/en-US/docs/Web/CSS/resolution as well as the compat data and the mdn/data data.

Marking dev-doc-complete, but please let me know if we need anything else.