Closed Bug 1460584 Opened 6 years ago Closed 2 years ago

[Dev Tools] Performance tab not saved in Default Developer Tools inside Browser Toolbox

Categories

(DevTools :: General, defect, P3)

61 Branch
defect

Tracking

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 fix-optional, firefox62 affected)

RESOLVED WORKSFORME
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- fix-optional
firefox62 --- affected

People

(Reporter: zstimi, Unassigned)

References

(Blocks 1 open bug)

Details

[Affected versions]: 
- Firefox 61.0b3

[Affected platforms]:
- Windows 7 x 64
- Mac OS X 10.13
- Ubuntu 14.04 x64.

[Steps to reproduce]:

1. Open Firefox. 
2. Open the Inspector by pressing F12. 
3. Click on the Meatball Menu and click on settings menu item.
4. From Advanced settings section enable "Enable browser chrome and add-on debugging toolboxes" and "Enable remote debugging", then go to Tools -> Web Developer -> Browser Toolbox to display the Developer Tools window.
5. Click on the Meatball Menu/Settings then from Default Developer Tools section check Performance item.
6. Close the Developer Tools window then reopen it.

[Expected result]:
After reopen the Developer Tools window the Performance tab should be saved, displayed in menu, verified in Meatball Menu/Settings Default Developer Tools section the Performance item should be checked. 

[Actual result]:
The Performance tab is not displayed in Developer Tools window menu and is unchecked in Meatball/Settings Default Developer Tools section.
Brian, do you think this could somehow be related to bug 1457278?
Flags: needinfo?(bgrinstead)
Priority: -- → P2
(In reply to Patrick Brosset <:pbro> from comment #1)
> Brian, do you think this could somehow be related to bug 1457278?

Yes, the pref gets reset to false at Browser Toolbox startup so it will never be included in the default set. We could probably fix this with a second pref to track whether the user has added perf (or something like that). But, given the discussion / justification for removing it from the default set in that bug I don't see a benefit to doing that. Devs should instead use https://perf-html.io/ to get better and more shareable profiles.

I wonder if we should instead hide the checkbox for the Performance tool in the Browser Toolbox options to prevent confusion. Timea, do you have a use-case for using the Performance tool from the Browser Toolbox?
Blocks: 1457278
Flags: needinfo?(bgrinstead) → needinfo?(timea.zsoldos)
Summary: [Dev Tools] Performance tab not saved in Default Developer Tools → [Dev Tools] Performance tab not saved in Default Developer Tools inside Browser Toolbox
In my opinion could be a solution for this issue, to hide the checkbox for the Performance tool in the Browser Toolbox option, like Shader Editor, Canvas and Web Audio tools. I found this issue when I tested "Improved Developer Tools tab bar navigation" feature, there is a test about saving and loading the tabs order preference.
Flags: needinfo?(timea.zsoldos)
No longer depends on: 1444299
If there is something about this that blocks the re-ordering feature, it should probably block that bug.
Blocks: 1226272
No longer blocks: 1444299
Product: Firefox → DevTools
Moving this inactive P2 to the backlog (P3)
Priority: P2 → P3

we removed the old perf panel and show the new profiler now, which is working well and is enabled by default, so we can probably close this bug

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.