Closed Bug 1459455 Opened 6 years ago Closed 6 years ago

Allow changing the tab separator color

Categories

(WebExtensions :: Themes, defect, P1)

defect

Tracking

(firefox62 verified, firefox63 verified)

VERIFIED FIXED
mozilla62
Tracking Status
firefox62 --- verified
firefox63 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

      No description provided.
Assignee: nobody → ntim.bugs
Priority: -- → P1
Status: NEW → ASSIGNED
Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

https://reviewboard.mozilla.org/r/241904/#review253782

::: toolkit/components/extensions/test/browser/browser_ext_themes_tab_separators.js:12
(Diff revision 3)
> +  let extension = ExtensionTestUtils.loadExtension({
> +    manifest: {
> +      "theme": {
> +        "colors": {
> +          "accentcolor": "#000",
> +          "textcolor": TAB_TEXT_COLOR,

TAB_TEXT_COLOR isn't referenced anywhere else so we should remove this constant so the test is easier to follow. Right now it gives the appearance that this constant may be referenced at another place within the test.
Attachment #8973547 - Flags: review?(jaws) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6bd6395abb7
Allow changing the tab separator color. r=jaws
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/16f1a4771b09
Allow changing the tab separator color. r=jaws
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d67e33e20cbd
Revert accidentally-landed package-lock.json changes.
Flags: needinfo?(ntim.bugs)
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/16f1a4771b09
https://hg.mozilla.org/mozilla-central/rev/d67e33e20cbd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Product: Toolkit → WebExtensions
Added code example and image to https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme and updated the browser compatibility information. PR: https://github.com/mdn/browser-compat-data/pull/2349
Can we get a review on the docs change in c#12?

Also, Irene, remember to add an entry to the Fx62 rel notes to report this change: 
https://developer.mozilla.org/en-US/Firefox/Releases/62

Thanks both!
Flags: needinfo?(ntim.bugs)
(In reply to Irene Smith from comment #12)
> Added code example and image to
> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/
> theme and updated the browser compatibility information. PR:
> https://github.com/mdn/browser-compat-data/pull/2349

Looks great, thanks Irene!
Flags: needinfo?(ntim.bugs)
Attached image Bug1459455.png
This issue is verified as fixed on Firefox 63.0a1 (20180709221247) and Firefox 62.0b7 (20180709172241) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: