Open Bug 1458247 Opened 6 years ago Updated 2 years ago

Internal compiler error on media/webrtc/trunk/webrtc/modules/video_coding/sequence_number_util.h using VS 15.7 Preview

Categories

(Core :: WebRTC, defect, P5)

Product:
Core
Component:
WebRTC
Platform:
Unspecified
Windows
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox61 --- affected

People

(Reporter: xavier114fch, Unassigned)

Details

Got an internal compiler error during a Firefox compile on Windows 10 using VS 15.7 Preview 7.0. This is the error message.

34:44.83 z:\mozilla-inbound\media\webrtc\trunk\webrtc/modules/video_coding/sequence_number_util.h(101): fatal error C1001: An internal error has occurred in the compiler.
34:44.84 (compiler file 'f:\dd\vctools\compiler\cxxfe\sl\p1\c\outdname.c', line 5310)
34:44.84  To work around this problem, try simplifying or changing the program near the locations listed above.
34:44.86 Please choose the Technical Support command on the Visual C++
34:44.86  Help menu, or open the Technical Support help file for more information
34:44.88 C:\PROGRA~2\MICROS~3\Preview\COMMUN~1\VC\Tools\MSVC\1414~1.264\include\xutility(301): note: see reference to class template instantiation 'webrtc::DescendingSeqNumComp<uint16_t,0>' being compiled
34:44.88 C:\PROGRA~2\MICROS~3\Preview\COMMUN~1\VC\Tools\MSVC\1414~1.264\include\xutility(301): note: see reference to variable template 'const bool is_empty_v<webrtc::DescendingSeqNumComp<unsigned short,0> >' being compiled
34:44.89 C:\PROGRA~2\MICROS~3\Preview\COMMUN~1\VC\Tools\MSVC\1414~1.264\include\xtree(1078): note: see reference to class template instantiation 'std::_Tree_comp_alloc<_Traits>' being compiled
34:44.91         with
34:44.92         [
34:44.94             _Traits=std::_Tmap_traits<uint16_t,webrtc::NackModule::NackInfo,webrtc::DescendingSeqNumComp<uint16_t,0>,std::allocator<std::pair<const uint16_t,webrtc::NackModule::NackInfo>>,false>
34:45.01         ]
34:45.02 C:\PROGRA~2\MICROS~3\Preview\COMMUN~1\VC\Tools\MSVC\1414~1.264\include\map(82): note: see reference to class template instantiation 'std::_Tree<std::_Tmap_traits<_Kty,_Ty,_Pr,_Alloc,false>>' being compiled
34:45.02         with
34:45.04         [
34:45.04             _Kty=uint16_t,
34:45.05             _Ty=webrtc::NackModule::NackInfo,
34:45.07             _Pr=webrtc::DescendingSeqNumComp<uint16_t,0>,
34:45.08             _Alloc=std::allocator<std::pair<const uint16_t,webrtc::NackModule::NackInfo>>
34:45.09         ]
34:45.11 z:\mozilla-inbound\media\webrtc\trunk\webrtc/modules/video_coding/nack_module.h(86): note: see reference to class template instantiation 'std::map<uint16_t,webrtc::NackModule::NackInfo,webrtc::DescendingSeqNumComp<uint16_t,0>,std::allocator<std::pair<const _Kty,_Ty>>>' being compiled
34:45.13         with
34:45.13         [
34:45.15             _Kty=uint16_t,
34:45.15             _Ty=webrtc::NackModule::NackInfo
34:45.15         ]
34:45.16 mozmake.EXE[4]: *** [z:/mozilla-inbound/config/rules.mk:1026: Unified_cpp_webrtc_call_call_gn0.obj] Error 2
34:45.16 mozmake.EXE[3]: *** [z:/mozilla-inbound/config/recurse.mk:73: media/webrtc/trunk/webrtc/call/call_gn/target] Error 2

This happened with a mozconfig file compiled to a 64-bit build, and without a mozconfig file compiled to a 32-bit build.
Have you reported this to Microsoft? If we bring it to their attention quickly, perhaps they may release a fix in time for 15.7.
Thanks Ryan!
Hopefully this will be fixed upstream.
Status: UNCONFIRMED → NEW
Rank: 45
Ever confirmed: true
Priority: -- → P5
Not fixed in final 15.7.0
Busted in 15.8 Preview 1 as well.
So, which compiler do you use guys for build browser now? I tried to build FF 60 with Visual Studio 2017 Professional (15.7.0), have this problem.
15.6.7 is fine for SeaMonkey so should be ok for Firefox too:

https://docs.microsoft.com/en-us/visualstudio/productinfo/installing-an-earlier-release-of-vs2017

Just make sure it doesn't autoupdate.

I am always create an offline install layout and tuck it away for an easy reinstall:
d:\vs_community.exe --layout D:\VS2017-15.6 --lang en-US

With all components around 33GB !
ok, will do the same. Thanks, @frg
Is 15.7.3 good to go now?
AFAIK, the fix hasn't been backported to 15.7.x. MS claims it's fixed in 15.8 preview 3.
Installed 15.8 preview 3 today. 

It compiles SeaMonkey 2.57 in esr60 now but the program just crashes during startup. 

Same for SeaMonkey 2.49 / ESR 52 and 2.53 / release 56 with backported VS2017 support. 

Didn't try to compile Firefox or Thunderbird.

Diagnosing compiler bugs is above my paygrade so I will just wait till 15.8 it goes GA and then try again.

The crash stats are useless because local build without debug infromation and symbols:
https://crash-stats.mozilla.com/report/index/f3ad5d0d-838c-4357-a246-b1db00180628

Stash away 15.6.7 in case this turns out bad also.
Visual Studio 15.8.0 has now been released (https://docs.microsoft.com/en-us/visualstudio/install/visual-studio-build-numbers-and-release-dates). Is this version good to build Firefox?
(In reply to Ian Gralinski from comment #13)
> Visual Studio 15.8.0 has now been released
> (https://docs.microsoft.com/en-us/visualstudio/install/visual-studio-build-
> numbers-and-release-dates). Is this version good to build Firefox?

I haven't tried myself but it sounds like it should be possible if you apply bug 1484184 and bug 1484190.
(In reply to David Major [:dmajor] from comment #14)
> (In reply to Ian Gralinski from comment #13)
> > Visual Studio 15.8.0 has now been released
> > (https://docs.microsoft.com/en-us/visualstudio/install/visual-studio-build-
> > numbers-and-release-dates). Is this version good to build Firefox?
> 
> I haven't tried myself but it sounds like it should be possible if you apply
> bug 1484184 and bug 1484190.

After applying the patches I can build successfully.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.