Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact mboldan@mozilla.com Reporter
	Description • 6 years ago

[Affected versions]:
 Fx 61.0a1


[Affected platforms]:
 Windows 10 x64
 Windows 7 x64
 Ubunut 16.04 LTS x86
 mac OS 10.13

[Steps to reproduce]:
 1. Launch Firefox.
 2. Go to "about:preferences#search" and select Wikipedia from the Default Search Engine dropdown list.
 3. Open a new tab. 

[Expected result]:
 The Wikipedia icon is displayed without issues in the search bar of the new tab. 

[Actual result]:
 The Wikipedia icon is not displayed accordingly

[Regression range]:
 This is not a regression as it reproduces since the feature landed in nightly (2018-04-21).

[Additional notes]:
 Please note the attachment with the issue.

	Mike Kaply [:mkaply]
	Comment 1 • 6 years ago

Attachment is missing. I don't see this on beta at least. Haven't tried nightly.

	Francesco Lodolo [:flod] Assignee
	Comment 2 • 6 years ago

Wondering, from the description, if this is an Activity Stream bug more than Search.

The Wikipedia icons has rounder borders, so the corner are transparent. I guess the problem is that the background of the image is not set.
https://searchfox.org/mozilla-central/source/browser/locales/searchplugins/images

	Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact mboldan@mozilla.com Reporter
	Comment 3 • 6 years ago

Here is the attachment.

	Francesco Lodolo [:flod] Assignee
	Comment 4 • 6 years ago

(In reply to Francesco Lodolo [:flod] from comment #2)
> The Wikipedia icons has rounder borders, so the corner are transparent. I
> guess the problem is that the background of the image is not set.

Weird. Amazon and Ebay have the same rounded corners, and yet they don't show any artifact.

	Mike Kaply [:mkaply]
	Comment 5 • 6 years ago

Definitely low resolution only. I'm thinking we should just put the amazon corners over the wikipedia corners in the low res ico.

	Dale Harvey (:daleharvey)
	Comment 6 • 6 years ago

yeh this is weird, will take a look

	Dale Harvey (:daleharvey)
	Comment 7 • 6 years ago

ok yup, the corners on the wikipedia icon at lower res are more rounded, leading to fully transparent corners which when processed via createObjectURL are getting rendered dark / black

Easiest fix would be a new icon, mkaply do you know who would be good to ask for that? this will probably need uplifted

	Mike Kaply [:mkaply]
	Comment 8 • 6 years ago

First thing we should do is see if wikipedia has a better version.

https://en.wikipedia.org/favicon.ico

Otherwise flod usually helps out with this.

	Dale Harvey (:daleharvey)
	Comment 9 • 6 years ago

Tested the current wikipedia favicon, it has an extra image in its .ico and suffers the same problem

Flod could you steal this bug and put the corners from the amazon icon onto the wikipedia icon here? I am going to take a look into a code fix for this (ie support transparency) however I do not expect it to be trivial and this is likely going to need an uplift so I think changing the icon is the least risky option

	Francesco Lodolo [:flod] Assignee
	Comment 10 • 6 years ago

I think we're actually using Wikipedia's favicon, just removing the 48px image from it. 

I can definitely build an icon without corners, and that's not a problem for Wikimedia's guidelines (#10), since there are no constraints for the frame
https://wikimediafoundation.org/wiki/Visual_identity_guidelines

On a side note: I can reproduce this, and the border goes away if you zoom: it starts disappearing at 170%, and goes away completely at 200$.

	Drew Willcoxon :adw
	Comment 12 • 6 years ago
mozreview-review

Comment on attachment 8971955 [details]
Bug 1457122 - Remove rounded corners in Wikipedia search plugin icon

https://reviewboard.mozilla.org/r/240716/#review246514

	Pulsebot
	Comment 13 • 6 years ago

Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/69b516d857cc
Remove rounded corners in Wikipedia search plugin icon r=adw

	Andreea Pavel [:apavel]
	Comment 14 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/69b516d857cc

	Francesco Lodolo [:flod] Assignee
	Comment 15 • 6 years ago

I can't see the borders anymore on 61.0a1 (2018-05-01) (64 bit)

I don't think it's wort fixing in 60, given that it requires someone to set Wikipedia as default search engine.

	Julien Cristau [:jcristau]
	Comment 16 • 6 years ago

Seems fair.