Closed
Bug 1456263
Opened 6 years ago
Closed 5 years ago
ChannelMergerNode constructor should throw errors
Categories
(Core :: Web Audio, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: toy.raymond, Assigned: padenot)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36
Steps to reproduce:
This is very closely related to 1443224. The constructor for ChannelMergerNode should also not allow you to set channelCount and channelCountMode to invalid values. It currently does:
c = new AudioContext()
n = new ChannelMergerNode(c, {channelCount: 3, channelCountMode: "max"});
n.channelCount;
n.channelCountMode;
channelCount is set to 3, and channelCountMode is set to "max".
|
||
Updated•6 years ago
|
Component: Untriaged → Web Audio
Product: Firefox → Core
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Keywords: dev-doc-needed
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → padenot
Priority: P2 → P3
|
||
Updated•5 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88e3307169f7 Throw appropriate errors in the ChannelMergerNode ctor. r=karlt
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
|
||
Comment 4•5 years ago
|
||
Documentation complete:
- Rel note added to https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/70#APIs
- Exceptions section added to the constructor page: https://wiki.developer.mozilla.org/en-US/docs/Web/API/ChannelMergerNode/ChannelMergerNode#Exceptions
Let me know if you'd like to see anything else. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•